From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Usyskin <alexander.usyskin@intel.com>
Cc: Oren Weil <oren.jer.weil@intel.com>,
Tomas Winkler <tomasw@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next] mei: use kvmalloc for read buffer
Date: Sun, 13 Oct 2024 14:14:10 +0200 [thread overview]
Message-ID: <2024101343-proposal-gatherer-8c43@gregkh> (raw)
In-Reply-To: <20241013115314.1290051-1-alexander.usyskin@intel.com>
On Sun, Oct 13, 2024 at 02:53:14PM +0300, Alexander Usyskin wrote:
> Read buffer is allocated according to max message size,
> reported by the firmware and may reach 64K in systems
> with pxp client.
> Contiguous 64k allocation may fail under memory pressure.
> Read buffer is used as in-driver message storage and
> not required to be contiguous.
> Use kvmalloc to allow kernel to allocate non-contiguous
> memory in this case.
>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> ---
> drivers/misc/mei/client.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
What about this thread:
https://lore.kernel.org/all/20240813084542.2921300-1-rohiagar@chromium.org/
No attribution for the reporter? Does it solve their problem?
And why such a short line-length in the changelog?
Also, where is this memory pressure coming from, what is the root cause
and what commit does this fix? Stable backports needed? Anything else?
And who inside Intel reviewed this before sending this out? Why are
they not credited here properly?
thanks,
greg k-h
next prev parent reply other threads:[~2024-10-13 12:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-13 11:53 Alexander Usyskin
2024-10-13 12:14 ` Greg Kroah-Hartman [this message]
2024-10-13 14:22 ` Usyskin, Alexander
2024-10-13 15:07 ` Greg Kroah-Hartman
2024-10-14 13:15 ` Usyskin, Alexander
2024-10-14 13:24 ` Greg Kroah-Hartman
2024-10-14 14:43 ` Usyskin, Alexander
2024-10-14 19:05 ` Brian Geffon
2024-10-14 19:11 ` Brian Geffon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024101343-proposal-gatherer-8c43@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oren.jer.weil@intel.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®