From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F487156F3A for ; Mon, 14 Oct 2024 09:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728896582; cv=none; b=q4euQyjNmmNxO/wwrKmV6R2Q0E8YmWb+wCTHZ2oCZtmUkLB9pYt/gTZ/miu3f6H8+XzLYr8CsUAE3wUOV00bXyeO84Dy20y63SUFMlCEdtFh2Cr8G+LF8adF+Z7E9drOXq+bvub2GfPcVtpiV7M4l8tnlhfRRDB4KKw8YkQENfU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728896582; c=relaxed/simple; bh=2GisIUBe0IEWy+Sau5w4ZmES8kY8GzDvVOOez+Hfq+4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KiJV4p/Ce8PrLeySKX8mLLguRQ6e4px37WhiJxKSiHce3inotEofWYAW59t8ppSKPpspQomnK0EQ6084Eilfs7y1+rJbaEBVYbhghihAhYbgaGYQw173jv35nUXUxWVjkXLZk5jCxkqaWEWQDTsbhZvaxm6KTbiHaIROrZEYeOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LV+QAYY5; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LV+QAYY5" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-71e427e29c7so1408419b3a.3 for ; Mon, 14 Oct 2024 02:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728896579; x=1729501379; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=r6BlRxGFAWXdmmWyG/Jl2AYSWcJ7q9f3AYTt/GTL8Vs=; b=LV+QAYY56vzmsVZnIe/UZIbuDRBg4Taz6blK0MKyl4tQcumxn9sEHI4QjThzBFvh4d Pt0kzWhrzkBLP1LoVuj8DpxknUY8GPHUlWrWSeyIH0VRKK/YWSdJBRc/31nUhA1azdAd W/l9DUXMM8cC7ylPFtVy1DRjsFUo/Im6ZbDhT6FO90nPPo234BSa1k2x3ycJ+3wDOdK4 QLVP3tXdGeUM5xFbYQ2jFIzTl6cS8bOQRF7Q04jBP1PhiBlj/+qYd1kZCSagJOdh+6k1 WaJGspLM6DWbet8DwuAKsPfK2iU/ClakgHeIpyKr/S62fjvVrRwiBmVupx7/Kr6QNg29 0G+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728896579; x=1729501379; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r6BlRxGFAWXdmmWyG/Jl2AYSWcJ7q9f3AYTt/GTL8Vs=; b=nkiwUA099MqrF5OovSjcut+lpf7tJeJb4PbXWHOoNW1kVGlhqiqwQg1PgrgIXhpmkt DVL+YGvirc8gNlzaYlk93nHuZRFS3XJT4eIvI8Hmtz06QeLRLSu4cRfqnUX7z7iDTqB6 W98gHC6gj/Q/h5GmKlza+SJoXtQMeUDA/0hGD81eRQu8UIUIj6RwavfpiniPDnMJxGaq EgpUCVTVPx4v1zxtxE+599C0dtwfbj0sJ4aXVWwVTdKctnumihzMuuGt9ud9Y5XPGiQv zNsjPdGNkF1AjmDczl+fh+YWWh6x4fFMhNObVGz0TilAfmsEg92UTaxz7ipOnwq6FHfU xz+Q== X-Forwarded-Encrypted: i=1; AJvYcCWPdYV4vstzDTHsbVBUagSUmKr8VxQxfSBeJCc+IijsOZbyhPDsW5KtejKrgtMpABtiPoNo4HFeqbt49UE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4KlIYt2MQNMK993ZcmSQ/IBOhTyo0nm4QP/u33HF9vFXC6BnZ 1SMoBZ9n4L+G46/EqvE8WlQMFUIBD20GdZESYCCAwy2Tqfirv1l5aNGbAxHrTw== X-Google-Smtp-Source: AGHT+IEd4NMKPXw0+kEcZfxjlbat70LgfJ4YvfVvn2VjB+W9S14ALVCgSnHKZNhydjKJLkZrc0GTQg== X-Received: by 2002:a05:6a00:1391:b0:71e:ba5:820e with SMTP id d2e1a72fcca58-71e4c1dcd95mr11403576b3a.27.1728896579444; Mon, 14 Oct 2024 02:02:59 -0700 (PDT) Received: from thinkpad ([220.158.156.88]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e6283e9f4sm2013750b3a.187.2024.10.14.02.02.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 02:02:59 -0700 (PDT) Date: Mon, 14 Oct 2024 14:32:51 +0530 From: Manivannan Sadhasivam To: Krzysztof Kozlowski Cc: Qiang Yu , vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, andersson@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, abel.vesa@linaro.org, quic_msarkar@quicinc.com, quic_devipriy@quicinc.com, dmitry.baryshkov@linaro.org, kw@linux.com, lpieralisi@kernel.org, neil.armstrong@linaro.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v6 3/8] dt-bindings: PCI: qcom,pcie-x1e80100: Add 'global' interrupt Message-ID: <20241014090251.r4sfaaxtasokv4oi@thinkpad> References: <20241011104142.1181773-1-quic_qianyu@quicinc.com> <20241011104142.1181773-4-quic_qianyu@quicinc.com> <4802B12B-BAC1-4E99-BDFE-A2340F4A8F24@linaro.org> <3d1d0822-da66-44c8-a328-69804210123c@kernel.org> <65B34B14-76C3-491D-8A58-6D0887889018@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Oct 11, 2024 at 06:06:02PM +0200, Krzysztof Kozlowski wrote: > On 11/10/2024 17:51, Manivannan Sadhasivam wrote: > > > > > > On October 11, 2024 9:14:31 PM GMT+05:30, Krzysztof Kozlowski wrote: > >> On 11/10/2024 17:42, Manivannan Sadhasivam wrote: > >>> > >>> > >>> On October 11, 2024 8:03:58 PM GMT+05:30, Krzysztof Kozlowski wrote: > >>>> On Fri, Oct 11, 2024 at 03:41:37AM -0700, Qiang Yu wrote: > >>>>> Document 'global' SPI interrupt along with the existing MSI interrupts so > >>>>> that QCOM PCIe RC driver can make use of it to get events such as PCIe > >>>>> link specific events, safety events, etc. > >>>> > >>>> Describe the hardware, not what the driver will do. > >>>> > >>>>> > >>>>> Though adding a new interrupt will break the ABI, it is required to > >>>>> accurately describe the hardware. > >>>> > >>>> That's poor reason. Hardware was described and missing optional piece > >>>> (because according to your description above everything was working > >>>> fine) is not needed to break ABI. > >>>> > >>> > >>> Hardware was described but not completely. 'global' IRQ let's the controller driver to handle PCIe link specific events like Link up, Link down etc... They improve user experience like the driver can use those interrupts to start bus enumeration on its own. So breaking the ABI for good in this case. > >>> > >>>> Sorry, if your driver changes the ABI for this poor reason. > >>>> > >>> > >>> Is the above reasoning sufficient? > >> > >> I tried to look for corresponding driver change, but could not, so maybe > >> there is no ABI break in the first place. > > > > Here it is: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4581403f67929d02c197cb187c4e1e811c9e762a > > > > Above explanation is good, but > >> still feels like improvement and device could work without global clock. > > So there is no ABI break in the first place... Commit is misleading. > It increases the 'minItems' to 9 from 8, how come it is not an ABI break? - Mani -- மணிவண்ணன் சதாசிவம்