From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2BC81EABD1; Tue, 15 Oct 2024 10:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728988404; cv=none; b=KaAK2ESVH1nf4iHKmFF8XzG15u7lpQuCDwmThs9AfuGMnlPuJGqqlcSlvUoE9DltzUJ486BmYKMBdiyx0H6o53rN5xKSCuwdYYstSO9ARhofvdX4G95bz+qKXHGAgY8ZgwnV+2JHInFu9LkXq8BNjulapaglPZLfFQxkrM6GE8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728988404; c=relaxed/simple; bh=2/4Bk4cdVMub6zRLUGlyW/pByzjfL6z36ldid4qPDdQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pm2+Po/T3Q2yXInfDpVlLoWxCNaOYm/BQoRcv19h6apG+RpEPYx+31ckZftcWKC0Ex3Z8hOozgptbS2I4R2/zw5YbE3bo4e5pL304mowa+3VAgQEfZlc8G+Fak1eU6p2q9/4QPeqU2vOVP9gqHoCIw33Rg2dDEWhqzzkwEhdSe8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=FLN1st6w; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="FLN1st6w" Received: from pendragon.ideasonboard.com (unknown [185.143.39.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B5439CE; Tue, 15 Oct 2024 12:31:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1728988299; bh=2/4Bk4cdVMub6zRLUGlyW/pByzjfL6z36ldid4qPDdQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FLN1st6wwAguQgsMaUKm8AYkeDjg8IOLzNSRyN4gPfkdyVP8AH2ds6acgtkrKXFhT fEGukvOq6WOngRpVD2AfKZbS5Q0V22g6lWSy8FiRJUkLz5rbiZ3u1P/GPqKA+5zSGM Lpj+uYCgAs8W4UPLsMpwJIjZ4UAbz7K9PwNN1bYU= Date: Tue, 15 Oct 2024 13:33:17 +0300 From: Laurent Pinchart To: Prabhakar Cc: Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das , Fabrizio Castro , Lad Prabhakar Subject: Re: [PATCH v5 15/22] media: rzg2l-cru: Make use of v4l2_format_info() helpers Message-ID: <20241015103317.GJ5682@pendragon.ideasonboard.com> References: <20241011173052.1088341-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20241011173052.1088341-16-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241011173052.1088341-16-prabhakar.mahadev-lad.rj@bp.renesas.com> Hi Prabhakar, Thank you for the patch. On Fri, Oct 11, 2024 at 06:30:45PM +0100, Prabhakar wrote: > From: Lad Prabhakar > > Make use of v4l2_format_info() helpers to determine the input and > output formats. > > Signed-off-by: Lad Prabhakar > --- > .../platform/renesas/rzg2l-cru/rzg2l-video.c | 22 ++++++------------- > 1 file changed, 7 insertions(+), 15 deletions(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index 8932fab7c656..0cc69a7440bf 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -300,21 +300,12 @@ static void rzg2l_cru_initialize_axi(struct rzg2l_cru_dev *cru) > rzg2l_cru_write(cru, AMnAXIATTR, amnaxiattr); > } > > -static void rzg2l_cru_csi2_setup(struct rzg2l_cru_dev *cru, bool *input_is_yuv, > +static void rzg2l_cru_csi2_setup(struct rzg2l_cru_dev *cru, > const struct rzg2l_cru_ip_format *ip_fmt, > u8 csi_vc) > { > u32 icnmc = ICnMC_INF(ip_fmt->datatype); > > - switch (ip_fmt->code) { > - case MEDIA_BUS_FMT_UYVY8_1X16: > - *input_is_yuv = true; > - break; > - default: > - *input_is_yuv = false; > - break; > - } > - > icnmc |= (rzg2l_cru_read(cru, ICnMC) & ~ICnMC_INF_MASK); > > /* Set virtual channel CSI2 */ > @@ -327,19 +318,17 @@ static int rzg2l_cru_initialize_image_conv(struct rzg2l_cru_dev *cru, > struct v4l2_mbus_framefmt *ip_sd_fmt, > u8 csi_vc) > { > + const struct v4l2_format_info *src_finfo, *dst_finfo; > const struct rzg2l_cru_ip_format *cru_ip_fmt; > - bool output_is_yuv = false; > - bool input_is_yuv = false; > u32 icndmr; > > cru_ip_fmt = rzg2l_cru_ip_code_to_fmt(ip_sd_fmt->code); > - rzg2l_cru_csi2_setup(cru, &input_is_yuv, cru_ip_fmt, csi_vc); > + rzg2l_cru_csi2_setup(cru, cru_ip_fmt, csi_vc); > > /* Output format */ > switch (cru->format.pixelformat) { > case V4L2_PIX_FMT_UYVY: > icndmr = ICnDMR_YCMODE_UYVY; > - output_is_yuv = true; > break; > default: > dev_err(cru->dev, "Invalid pixelformat (0x%x)\n", > @@ -347,8 +336,11 @@ static int rzg2l_cru_initialize_image_conv(struct rzg2l_cru_dev *cru, > return -EINVAL; > } > > + src_finfo = v4l2_format_info(cru_ip_fmt->format); > + dst_finfo = v4l2_format_info(cru->format.pixelformat); It would be a bit more efficient to add a yuv boolean field to the rzg2l_cru_ip_format structure, as you already have looked up cru_ip_fmt for the IP subdev format. Reviewed-by: Laurent Pinchart > + > /* If input and output use same colorspace, do bypass mode */ > - if (output_is_yuv == input_is_yuv) > + if (v4l2_is_format_yuv(src_finfo) == v4l2_is_format_yuv(dst_finfo)) > rzg2l_cru_write(cru, ICnMC, > rzg2l_cru_read(cru, ICnMC) | ICnMC_CSCTHR); > else -- Regards, Laurent Pinchart