From: mripard@kernel.org
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
airlied@gmail.com, simona@ffwll.ch, christian.koenig@amd.com,
ray.huang@amd.com, dmitry.baryshkov@linaro.org,
dave.stevenson@raspberrypi.com, mcanal@igalia.com,
quic_jjohnson@quicinc.com, skhan@linuxfoundation.org,
davidgow@google.com, karolina.stolarek@intel.com,
Arunpravin.PaneerSelvam@amd.com,
thomas.hellstrom@linux.intel.com, asomalap@amd.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()
Date: Wed, 16 Oct 2024 11:36:54 +0200 [thread overview]
Message-ID: <20241016-functional-funky-boar-0ccadc@houat> (raw)
In-Reply-To: <20241014125204.1294934-3-ruanjinjie@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]
On Mon, Oct 14, 2024 at 08:52:02PM GMT, Jinjie Ruan wrote:
> modprobe drm_connector_test and then rmmod drm_connector_test,
> the following memory leak occurs.
>
> The `mode` allocated in drm_mode_duplicate() called by
> drm_display_mode_from_cea_vic() is not freed, which cause the memory leak:
>
> unreferenced object 0xffffff80cb0ee400 (size 128):
> comm "kunit_try_catch", pid 1948, jiffies 4294950339
> hex dump (first 32 bytes):
> 14 44 02 00 80 07 d8 07 04 08 98 08 00 00 38 04 .D............8.
> 3c 04 41 04 65 04 00 00 05 00 00 00 00 00 00 00 <.A.e...........
> backtrace (crc 90e9585c):
> [<00000000ec42e3d7>] kmemleak_alloc+0x34/0x40
> [<00000000d0ef055a>] __kmalloc_cache_noprof+0x26c/0x2f4
> [<00000000c2062161>] drm_mode_duplicate+0x44/0x19c
> [<00000000f96c74aa>] drm_display_mode_from_cea_vic+0x88/0x98
> [<00000000d8f2c8b4>] 0xffffffdc982a4868
> [<000000005d164dbc>] kunit_try_run_case+0x13c/0x3ac
> [<000000006fb23398>] kunit_generic_run_threadfn_adapter+0x80/0xec
> [<000000006ea56ca0>] kthread+0x2e8/0x374
> [<000000000676063f>] ret_from_fork+0x10/0x20
> ......
>
> Free `mode` by using drm_kunit_helper_display_mode_from_cea_vic()
> to fix it.
>
> Cc: stable@vger.kernel.org
> Fixes: abb6f74973e2 ("drm/tests: Add HDMI TDMS character rate tests")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
next prev parent reply other threads:[~2024-10-16 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 12:52 [PATCH v2 0/4] drm: Fix some memory leaks Jinjie Ruan
2024-10-14 12:52 ` [PATCH v2 1/4] drm/tests: helpers: Add helper for drm_display_mode_from_cea_vic() Jinjie Ruan
2024-10-16 9:35 ` Maxime Ripard
2024-10-17 1:33 ` Jinjie Ruan
2024-10-17 12:13 ` Maxime Ripard
2024-10-17 12:16 ` Jinjie Ruan
2024-10-14 12:52 ` [PATCH v2 2/4] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic() Jinjie Ruan
2024-10-16 9:36 ` mripard [this message]
2024-10-14 12:52 ` [PATCH v2 3/4] drm/ttm/tests: Fix memory leak in ttm_tt_simple_create() Jinjie Ruan
2024-10-14 13:38 ` Jeff Johnson
2024-10-14 12:52 ` [PATCH v2 4/4] drm/tests: hdmi: Fix memory leaks in drm_display_mode_from_cea_vic() Jinjie Ruan
2024-10-16 9:37 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016-functional-funky-boar-0ccadc@houat \
--to=mripard@kernel.org \
--cc=Arunpravin.PaneerSelvam@amd.com \
--cc=airlied@gmail.com \
--cc=asomalap@amd.com \
--cc=christian.koenig@amd.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=davidgow@google.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=karolina.stolarek@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=quic_jjohnson@quicinc.com \
--cc=ray.huang@amd.com \
--cc=ruanjinjie@huawei.com \
--cc=simona@ffwll.ch \
--cc=skhan@linuxfoundation.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®