mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yi Sun <yi.sun@unisoc.com>
To: <chao@kernel.org>
Cc: <jaegeuk@kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>,
	<linux-kernel@vger.kernel.org>, <yi.sun@unisoc.com>,
	<sunyibuaa@gmail.com>, <niuzhiguo84@gmail.com>,
	<hao_hao.wang@unisoc.com>, <ke.wang@unisoc.com>
Subject: [RFC PATCH 0/2] Speed up f2fs truncate
Date: Wed, 16 Oct 2024 13:27:56 +0800	[thread overview]
Message-ID: <20241016052758.3400359-1-yi.sun@unisoc.com> (raw)

Deleting large files is time-consuming, and a large part
of the time is spent in f2fs_invalidate_blocks()
->down_write(sit_info->sentry_lock) and up_write().

If some blocks are continuous and belong to the same segment,
we can process these blocks at the same time. This can reduce
the number of calls to the down_write() and the up_write(),
thereby improving the overall speed of doing truncate.

Test steps:
Set the CPU and DDR frequencies to the maximum.
dd if=/dev/random of=./test.txt bs=1M count=100000
sync
rm test.txt

Time Comparison of rm:
original        optimization            ratio
7.17s		3.27s			54.39%

Hi, currently I have only optimized the f2fs doing truncate route,
and other functions using f2fs_invalidate_blocks() are not taken
into consideration. So new function
f2fs_invalidate_compress_pages_range() and
check_f2fs_invalidate_consecutive_blocks() are not general functions.
Is this modification acceptable?

Yi Sun (2):
  f2fs: introduce update_sit_entry_for_release()
  f2fs: introduce f2fs_invalidate_consecutive_blocks() for truncate

 fs/f2fs/compress.c |  14 ++++++
 fs/f2fs/f2fs.h     |   5 ++
 fs/f2fs/file.c     |  34 ++++++++++++-
 fs/f2fs/segment.c  | 116 +++++++++++++++++++++++++++++++--------------
 4 files changed, 133 insertions(+), 36 deletions(-)

-- 
2.25.1


             reply	other threads:[~2024-10-16  5:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16  5:27 Yi Sun [this message]
2024-10-16  5:27 ` [RFC PATCH 1/2] f2fs: introduce update_sit_entry_for_release() Yi Sun
2024-10-16  5:27 ` [RFC PATCH 2/2] f2fs: introduce f2fs_invalidate_consecutive_blocks() Yi Sun
2024-10-16 16:04   ` Jaegeuk Kim
2024-10-17  1:40   ` Chao Yu
2024-10-24  9:54     ` yi sun
2024-10-24 10:26       ` Chao Yu
2024-10-29  3:02         ` yi sun
2024-10-28 17:40 ` [f2fs-dev] [RFC PATCH 0/2] Speed up f2fs truncate patchwork-bot+f2fs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241016052758.3400359-1-yi.sun@unisoc.com \
    --to=yi.sun@unisoc.com \
    --cc=chao@kernel.org \
    --cc=hao_hao.wang@unisoc.com \
    --cc=jaegeuk@kernel.org \
    --cc=ke.wang@unisoc.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niuzhiguo84@gmail.com \
    --cc=sunyibuaa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®