From: Gou Hao <gouhao@uniontech.com>
To: xiang@kernel.org, chao@kernel.org
Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
gouhaojake@163.com
Subject: [PATCH 1/2] erofs: using macro instead of definition of log functions
Date: Wed, 16 Oct 2024 23:24:29 +0800 [thread overview]
Message-ID: <20241016152430.3456-1-gouhao@uniontech.com> (raw)
No functional change intended.
Signed-off-by: Gou Hao <gouhao@uniontech.com>
---
fs/erofs/super.c | 51 ++++++++++++++++++------------------------------
1 file changed, 19 insertions(+), 32 deletions(-)
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 666873f745da..b04f888c8123 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -18,39 +18,26 @@
static struct kmem_cache *erofs_inode_cachep __read_mostly;
-void _erofs_err(struct super_block *sb, const char *func, const char *fmt, ...)
-{
- struct va_format vaf;
- va_list args;
-
- va_start(args, fmt);
-
- vaf.fmt = fmt;
- vaf.va = &args;
-
- if (sb)
- pr_err("(device %s): %s: %pV", sb->s_id, func, &vaf);
- else
- pr_err("%s: %pV", func, &vaf);
- va_end(args);
-}
-
-void _erofs_info(struct super_block *sb, const char *func, const char *fmt, ...)
-{
- struct va_format vaf;
- va_list args;
-
- va_start(args, fmt);
-
- vaf.fmt = fmt;
- vaf.va = &args;
+#define _erofs_log_def(name) \
+ void _erofs_##name(struct super_block *sb, const char *func, const char *fmt, ...) \
+ { \
+ struct va_format vaf; \
+ va_list args; \
+ \
+ va_start(args, (fmt)); \
+ \
+ vaf.fmt = (fmt); \
+ vaf.va = &args; \
+ \
+ if ((sb)) \
+ pr_##name("(device %s): %s: %pV", (sb)->s_id, (func), &vaf); \
+ else \
+ pr_##name("%s: %pV", (func), &vaf); \
+ va_end(args); \
+ }
- if (sb)
- pr_info("(device %s): %pV", sb->s_id, &vaf);
- else
- pr_info("%pV", &vaf);
- va_end(args);
-}
+_erofs_log_def(err);
+_erofs_log_def(info);
static int erofs_superblock_csum_verify(struct super_block *sb, void *sbdata)
{
--
2.20.1
next reply other threads:[~2024-10-16 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 15:24 Gou Hao [this message]
2024-10-16 15:24 ` [PATCH 2/2] erofs: simplify declaration of the " Gou Hao
2024-10-17 3:42 ` Gao Xiang
2024-10-17 3:39 ` [PATCH 1/2] erofs: using macro instead of definition of " Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016152430.3456-1-gouhao@uniontech.com \
--to=gouhao@uniontech.com \
--cc=chao@kernel.org \
--cc=gouhaojake@163.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®