From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15D031D95BE; Thu, 17 Oct 2024 17:52:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729187529; cv=none; b=jAxIG09y17Paf12XZV8azHmyKEGHZluzmPGhEUY9Ec32bhcCHv2P4hZcD5rBd8vMeztW+WkBLpq2Q6j73XA5xRDVzh6PF0gT8U7I4kzvSugyZ80IgPwdbPratdlynNyG4ObdH1T1vUP/Ua8r93rQ7MkuJmOW1cJqUMMLSmyktec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729187529; c=relaxed/simple; bh=gmOt13pVPmIXcY0OIAOohx40/5JMQplh61ctXWIWaUc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GHBRFn72T+3tHJUoSRBKh/ayCwm9JkD13WJWshH0lw2E4c0Vomdrp71MHJDtenH6+qechxvu4CEMmfusk3hHYPEYZ3wQlhUCNyO12CQyDEBpRM6TIlSHoVNQhEAjHiw5Oo93EmgNxIM4rahnnBmz+eP5u4OPh929Mwd/ZtnMbNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O2Az3lyt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O2Az3lyt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CDF8C4CEC3; Thu, 17 Oct 2024 17:52:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729187528; bh=gmOt13pVPmIXcY0OIAOohx40/5JMQplh61ctXWIWaUc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O2Az3lytMc3zjIDcqG16DuKCCGrBrOYDPGEDE39DOPaF2+SEcc8x39uCb8POps19L HjODyGTdz+Hb11q/lPG0+qeKi5OEb1lIWNl3cndhmy8kJW3x00D3NyjI7Cztxkhj5n BI5d62MLCV99uCGYtjovS+0cVhuLAeNtLE3HrQXcFXhcdW9Lx1ucSPsOl28k/guwpj 1a04lOMGGoCLygH1zWJUke7N1ryVFka/McFNlQy8kPRv9Ftmj0NIKRVQGyBMaYWG94 UjqqwdhXuX3g20yVPiO6HNo9/5jmUejo+TSSWKon+TPLTpYYTYMCuQdnVLriZtP/uC +4/8NN5GBBD2A== Date: Thu, 17 Oct 2024 18:52:04 +0100 From: Conor Dooley To: Changhuang Liang Cc: "linux-riscv@lists.infradead.org" , Conor Dooley , "stable@vger.kernel.org" , Aurelien Jarno , Emil Renner Berthing , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: =?utf-8?B?5Zue5aSNOiBbUEFUQw==?= =?utf-8?Q?H?= v1] riscv: dts: starfive: disable unused csi/camss nodes Message-ID: <20241017-condone-angelic-9d4936f1fd37@spud> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VgIo2QEZSi5NGsOb" Content-Disposition: inline In-Reply-To: --VgIo2QEZSi5NGsOb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 17, 2024 at 05:49:56AM +0000, Changhuang Liang wrote: > Hi, Conor, >=20 > > Hi, Conor > >=20 > > Thanks for your patch. > >=20 > > > From: Conor Dooley > > > > > > Aurelien reported probe failures due to the csi node being enabled > > > without having a camera attached to it. A camera was in the initial > > > submissions, but was removed from the dts, as it had not actually been > > > present on the board, but was from an addon board used by the develop= er > > of the relevant drivers. > > > The non-camera pipeline nodes were not disabled when this happened and > > > the probe failures are problematic for Debian. Disable them. > > > > > > CC: stable@vger.kernel.org > > > Fixes: 28ecaaa5af192 ("riscv: dts: starfive: jh7110: Add camera > > > subsystem > > > nodes") > >=20 > > Here you write it in 13 characters, should be "Fixes: 28ecaaa5af19 ..." > >=20 >=20 > After fixing this: > Reviewed-by: Changhuang Liang Ye, I know it was 13 not 12. I don't think that's a problem though. --VgIo2QEZSi5NGsOb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZxFOxAAKCRB4tDGHoIJi 0r24AQCKINQVQ9g7jUqAtlal7Z82+REbGOsv+I+oqRMQduOLKgD+K/ZCmiECTEgx z4CTuvZPyZwHRwjzkEUY9OmWxrRT2Ac= =nBzS -----END PGP SIGNATURE----- --VgIo2QEZSi5NGsOb--