mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mohammed Anees <pvmohammedanees2003@gmail.com>
To: pkshih@realtek.com
Cc: kvalo@kernel.org, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org, pvmohammedanees2003@gmail.com
Subject: Re: [PATCH] wifi: rtw88: Refactor looping in rtw_phy_store_tx_power_by_rate
Date: Thu, 17 Oct 2024 12:26:45 +0530	[thread overview]
Message-ID: <20241017065645.5409-1-pvmohammedanees2003@gmail.com> (raw)
In-Reply-To: <c0f6c6c3b87c4d048ad9f42dc1dfaed9@realtek.com>

Oops, I sent over the wrong patch with typo,
I'll make sure to fix that in the next version.

> I feel compilers can optimize the check for the band, and we can just remove
> the else condition. Or
>   if (2ghz)
>      foo_2g();
>   else
>      foo_5g();

I do agree with that but I feel, it would be
better to make it independent of compiler
optimization, thoughts?

Let me know what you think is better, that is 
whether letting it be if - else, or using a
pointer.

thanks

  reply	other threads:[~2024-10-17  6:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16  6:06 Mohammed Anees
2024-10-17  1:21 ` Ping-Ke Shih
2024-10-17  6:56   ` Mohammed Anees [this message]
2024-10-17  7:06     ` Ping-Ke Shih
2024-10-17  7:12       ` Mohammed Anees
2024-10-17  3:19 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241017065645.5409-1-pvmohammedanees2003@gmail.com \
    --to=pvmohammedanees2003@gmail.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®