From: Jan Kara <jack@suse.cz>
To: Alessandro Zanni <alessandro.zanni87@gmail.com>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, anupnewsmail@gmail.com,
alessandrozanni.dev@gmail.com,
syzbot+6c55f725d1bdc8c52058@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] fs: Fix uninitialized value issue in from_kuid and from_kgid
Date: Thu, 17 Oct 2024 15:06:10 +0200 [thread overview]
Message-ID: <20241017130610.sryqcth6e2yao3gx@quack3> (raw)
In-Reply-To: <20241017120553.55331-1-alessandro.zanni87@gmail.com>
On Thu 17-10-24 14:05:51, Alessandro Zanni wrote:
> ocfs2_setattr() uses attr->ia_mode, attr->ia_uid and attr->ia_gid in
> a trace point even though ATTR_MODE, ATTR_UID and ATTR_GID aren't set.
>
> Initialize all fields of newattrs to avoid uninitialized variables, by
> checking if ATTR_MODE, ATTR_UID, ATTR_GID are initialized, otherwise 0.
>
> Reported-by: syzbot+6c55f725d1bdc8c52058@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=6c55f725d1bdc8c52058
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
Thanks! The patch looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> Notes:
> v2: fix ocfs2_setattr to avoid similar issues; improved commit description
>
> fs/ocfs2/file.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index ad131a2fc58e..58887456e3c5 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -1129,9 +1129,12 @@ int ocfs2_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
> trace_ocfs2_setattr(inode, dentry,
> (unsigned long long)OCFS2_I(inode)->ip_blkno,
> dentry->d_name.len, dentry->d_name.name,
> - attr->ia_valid, attr->ia_mode,
> - from_kuid(&init_user_ns, attr->ia_uid),
> - from_kgid(&init_user_ns, attr->ia_gid));
> + attr->ia_valid,
> + attr->ia_valid & ATTR_MODE ? attr->ia_mode : 0,
> + attr->ia_valid & ATTR_UID ?
> + from_kuid(&init_user_ns, attr->ia_uid) : 0,
> + attr->ia_valid & ATTR_GID ?
> + from_kgid(&init_user_ns, attr->ia_gid) : 0);
>
> /* ensuring we don't even attempt to truncate a symlink */
> if (S_ISLNK(inode->i_mode))
> --
> 2.43.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-10-17 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 12:05 Alessandro Zanni
2024-10-17 13:06 ` Jan Kara [this message]
2024-10-17 13:32 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017130610.sryqcth6e2yao3gx@quack3 \
--to=jack@suse.cz \
--cc=alessandro.zanni87@gmail.com \
--cc=alessandrozanni.dev@gmail.com \
--cc=anupnewsmail@gmail.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+6c55f725d1bdc8c52058@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®