mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Alex Lanzano <lanzano.alex@gmail.com>
Cc: Yang Li <yang.lee@linux.alibaba.com>,
	lars@metafoo.de, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] iio: imu: bmi270: Remove duplicated include in bmi270_i2c.c
Date: Thu, 17 Oct 2024 18:55:07 +0100	[thread overview]
Message-ID: <20241017185507.547c5505@jic23-huawei> (raw)
In-Reply-To: <v3xzvojyycil7jszgxfnrwjiqxonz6aqrmfs6hgmru7pfuzgyv@3qrbzqo6p5mk>

On Tue, 15 Oct 2024 22:31:57 -0400
Alex Lanzano <lanzano.alex@gmail.com> wrote:

> On Wed, Oct 16, 2024 at 08:39:19AM +0800, Yang Li wrote:
> > The header files linux/module.h is included twice in bmi270_i2c.c,
> > so one inclusion of each can be removed.
> > 
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11363
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> >  drivers/iio/imu/bmi270/bmi270_i2c.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c
> > index e9025d22d5cc..71cc271cdf30 100644
> > --- a/drivers/iio/imu/bmi270/bmi270_i2c.c
> > +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
> > @@ -3,7 +3,6 @@
> >  #include <linux/module.h>
> >  #include <linux/i2c.h>
> >  #include <linux/iio/iio.h>
> > -#include <linux/module.h>
> >  #include <linux/mod_devicetable.h>
> >  #include <linux/regmap.h>  
> 
> Good catch!
> 
> Minor nit: Should remove the top module.h include instead to keep
> alphabetical ordering.
> 

Given I messed up the pull request anyway, I've snuck this one is
as an obviously fine last minute tidy up. With the other entry removed as
suggested.

      reply	other threads:[~2024-10-17 17:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16  0:39 Yang Li
2024-10-16  2:31 ` Alex Lanzano
2024-10-17 17:55   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241017185507.547c5505@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=abaci@linux.alibaba.com \
    --cc=lanzano.alex@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®