From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9546D227B85 for ; Thu, 17 Oct 2024 19:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729193283; cv=none; b=fFdVDOalPsofEA9lsoDUfdavJ7/+nEUhaQDqAKC/Wv4NibTbasBtV1XANSaOddcIlPHPtqYC58C2mxCG1wtxJl8bjsOP5wOYf0zbG5QgZXw5L7gKB4IKklTfi80Kza1AyC06QA2Ab8mPrFPy8no3IFWam3jn+UYQQ6YCPgcbTLo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729193283; c=relaxed/simple; bh=DYaBD1smhDImlEtRtnDp1C2vYjtmdoR9Ir7CbYzgY70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=piZdGYJTo2R2rOgCdMhpCZg74WSn5mLTVP3kdEKahm94K/I8LPI2a36lu+AvfXHribPkqeAlplm5neEmNtb5G3L5b4gnRhIKV2TsMibR8C5T4BT+kFKKPTPlscPJoGEPn0dwvj/aGN9OfilwHCDoD/GJBOpCByBp5y3J1uXRn4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=HT1t46N+; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="HT1t46N+" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-460963d6233so8105811cf.2 for ; Thu, 17 Oct 2024 12:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1729193280; x=1729798080; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QKztc68P1GiWB5LrK4Q2I6nYf1n+uL5P1Nl/QmLdvZk=; b=HT1t46N+c3O+RMDoBhrYPPG2yUaqXVuUHQFwRSibjryDBFZwBXv/p1bVMKqvAyJ3LE gQT8OylV6EFXAtnnmRyUiht2VENl41qR+/EuUF/KnTQkrGPeWHSMB75E511CW9W8TmdH xmAZYWndiQ9meqq3RT8oFCcCWqj7/Vb6RDgP1W3VzXeQQrSojYlZZOHNvcbhQxjm5LlO i0Pxj2bLGJO12I+fbMSWioVwVHUzj1kbCPv09MyQYN2ONkPQL94G2tgARBvtrvgnz3BE 2cqgp7+cE4Rpm0T4xLOFrXQtfenvegVlEMu0V63bRao/39itqYDRd1t1F41j+2PgSgOp Silw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729193280; x=1729798080; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QKztc68P1GiWB5LrK4Q2I6nYf1n+uL5P1Nl/QmLdvZk=; b=jlbYLDiEqHVnwdE3KI4WPZblHU+XcDATSZKW+tTMr4nBK1LIQq5UHb8P/NYIdwnmWW 8MvSevCNyi1suxPRh4IkEC5TR+jg1DB4gPnJeWWaZM7u1b/MhMXOfZgRInPn3sQcfrKj 96He7Fq6s1c015Uft0wbJr/ThxHUIn5dXj6ExkFX9qqiqcXfdLLCgOtCZaqq8+qswZPC od2pbsG+JhqSjnulJGTJWEmqn4I8r/Q+F3bwz6KaQvlxgzU/TuFAyTPQomKEwRFMlw03 Yh8/6CHx03vF/c04ovQPs/SkIjAYqQyeGhjN0mbAQMOwplsLBSlHOItS8M+ZHEt4XozH Uk9Q== X-Forwarded-Encrypted: i=1; AJvYcCWOR7byyHDs9gn30En24bt9Sx5E9OwPfxJlCBER2btF+w0m/9HoHtVD5NsejleITr9vC0IBcKzxJjfPxS8=@vger.kernel.org X-Gm-Message-State: AOJu0YzzD6Pab2U5PvmBQhaYBzE5febHtxIfUb+5O89WgC1L5JQvA3Gs yJmVhMyrl7Gr2Oi9zCEON7tSWBu9T1X/rnfrocNrob2WFXudICeJKXK2CIPL/Yc= X-Google-Smtp-Source: AGHT+IGHpRlR1WODf6TO074C3dG1TQmfT7rOPQMZN8r/XlTSeridiVkBkPMiYkzYHJHKcuDMpCqqbw== X-Received: by 2002:a05:622a:4819:b0:460:9ff9:6b41 with SMTP id d75a77b69052e-4609ff9710amr43875291cf.28.1729193280305; Thu, 17 Oct 2024 12:28:00 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4607b0a28e2sm30392291cf.1.2024.10.17.12.27.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 12:27:59 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1t1WAB-004nhW-9m; Thu, 17 Oct 2024 16:27:59 -0300 Date: Thu, 17 Oct 2024 16:27:59 -0300 From: Jason Gunthorpe To: Daisuke Matsuda Cc: linux-rdma@vger.kernel.org, leon@kernel.org, zyjzyj2000@gmail.com, linux-kernel@vger.kernel.org, rpearsonhpe@gmail.com, lizhijian@fujitsu.com Subject: Re: [PATCH for-next v8 0/6] On-Demand Paging on SoftRoCE Message-ID: <20241017192759.GC948948@ziepe.ca> References: <20241009015903.801987-1-matsuda-daisuke@fujitsu.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241009015903.801987-1-matsuda-daisuke@fujitsu.com> On Wed, Oct 09, 2024 at 10:58:57AM +0900, Daisuke Matsuda wrote: > This patch series implements the On-Demand Paging feature on SoftRoCE(rxe) > driver, which has been available only in mlx5 driver[1] so far. > > This series has been blocked because of the hang issue of srp 002 test[2], > which was believed to be caused after applying the commit 9b4b7c1f9f54 > ("RDMA/rxe: Add workqueue support for rxe tasks"). My patches are dependent > on the commit because the ODP feature requires sleeping in kernel space, > and it is impossible with the former tasklet implementation. > > According to the original reporter[3], the hang issue is already gone in > v6.10. Additionally, tasklet is marked deprecated[4]. I think the rxe > driver is ready to accept this series since there is no longer any reason > to consider reverting back to the old tasklet. Okay, and it seems we are just ignoring the rxe bugs these days, so why not? Lets look at it Jason