From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA669201007; Fri, 18 Oct 2024 09:54:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245281; cv=none; b=aSgqaLOdegQLiyFelTJ4oihnvnfQ6qWd4w8MUwkZhaVv+vWG1f85UXMkGDs1Kf6cqSKJubnZ9iSY+PwFl4X1NXREah+nVM/nN838fjGvtreP6MtpKGQTRNAvqpRWZ/0EvAtTETwX1nmbHnM9XbF6+3km0/yKjOF1v9N2UVjGw2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245281; c=relaxed/simple; bh=y8J1gMb6GjOQGDAWYefK/cBHIifkVuA6UgmIBYFPlUE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mSIid96orucOJKozBx98TCaaXnQYshgIy8pVhBomJ9JCUJ4kE6jPcU1H4Aa1pvq7GsPeXxaQKYTVsaBsXYdjTWOVDKQ5IK/gP/Si9xhdcy39yBnxys8NM0sgGA01quIEPVzLG4yhl+BWYAgkWwGSP+5BXkl3vIC6K0Yp1Oh28GQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ahAgEk0z; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=oFuBjuHY; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ahAgEk0z; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=oFuBjuHY; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ahAgEk0z"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="oFuBjuHY"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ahAgEk0z"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="oFuBjuHY" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 01AAD21DC1; Fri, 18 Oct 2024 09:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729245278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CFYRTWF15ddtTIFg4BWAxR2N8EgXFZHV0oxaHhkdnNg=; b=ahAgEk0zvzSSIQKUL6A814A0FQh5Ipctfq0BhVfFC8alaHTg9S3ZROEvSpX5X1LaJNClvf bnXj8udeOg2oRFZCCdQWjyeAt9bw/y0LPKVxsJPZXpEhrq03imopMPJ5oVnLZ3+kcamyn8 7oL7HdULCISOdNBdsUb8otGpzlKxZpM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729245278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CFYRTWF15ddtTIFg4BWAxR2N8EgXFZHV0oxaHhkdnNg=; b=oFuBjuHYSo7tV4kOJ8li0gcK975SC1ZvJIbYPhgffUBCO35Nj+nWZFcPS8hCL7ul1hMgE9 DblcD2auLZisyjCw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729245278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CFYRTWF15ddtTIFg4BWAxR2N8EgXFZHV0oxaHhkdnNg=; b=ahAgEk0zvzSSIQKUL6A814A0FQh5Ipctfq0BhVfFC8alaHTg9S3ZROEvSpX5X1LaJNClvf bnXj8udeOg2oRFZCCdQWjyeAt9bw/y0LPKVxsJPZXpEhrq03imopMPJ5oVnLZ3+kcamyn8 7oL7HdULCISOdNBdsUb8otGpzlKxZpM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729245278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CFYRTWF15ddtTIFg4BWAxR2N8EgXFZHV0oxaHhkdnNg=; b=oFuBjuHYSo7tV4kOJ8li0gcK975SC1ZvJIbYPhgffUBCO35Nj+nWZFcPS8hCL7ul1hMgE9 DblcD2auLZisyjCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 506CC13680; Fri, 18 Oct 2024 09:54:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id l1ChEV0wEmcvYwAAD6G6ig (envelope-from ); Fri, 18 Oct 2024 09:54:37 +0000 Date: Fri, 18 Oct 2024 11:54:35 +0200 From: Jean Delvare To: Doug Anderson Cc: dri-devel@lists.freedesktop.org, LKML , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , YueHaibing , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , linux-arm-msm , freedreno Subject: Re: [PATCH v3] drm/display: Drop obsolete dependency on COMPILE_TEST Message-ID: <20241018115435.3632cb10@endymion.delvare> In-Reply-To: References: <20241015134606.5b87093e@endymion.delvare> Organization: SUSE Linux X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-suse-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -4.30 X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[16]; HAS_ORG_HEADER(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[lists.freedesktop.org,vger.kernel.org,linux.intel.com,kernel.org,suse.de,gmail.com,ffwll.ch,huawei.com,quicinc.com,linaro.org,poorly.run,somainline.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO X-Spam-Level: Hi Doug, On Tue, 15 Oct 2024 09:06:04 -0700, Doug Anderson wrote: > On Tue, Oct 15, 2024 at 4:46=E2=80=AFAM Jean Delvare w= rote: > > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > > is possible to test-build any driver which depends on OF on any > > architecture by explicitly selecting OF. Therefore depending on > > COMPILE_TEST as an alternative is no longer needed. > > > > To avoid reintroducing the randconfig bug originally fixed by commit > > 876271118aa4 ("drm/display: Fix build error without CONFIG_OF"), > > DRM_MSM which selects DRM_DISPLAY_DP_HELPER must explicitly depend > > on OF. This is consistent with what all other DRM drivers are doing. > > > > Signed-off-by: Jean Delvare > > Reviewed-by: Javier Martinez Canillas > > Cc: David Airlie > > Cc: Daniel Vetter > > --- > > For regular builds, this is a no-op, as OF is always enabled on > > ARCH_QCOM and SOC_IMX5. So this change only affects test builds. As > > explained before, allowing test builds only when OF is enabled > > improves the quality of these test builds, as the result is then > > closer to how the code is built on its intended targets. > > > > Changes in v3: > > * Rebase on top of kernel v6.11. > > Changes in v2: > > * Let DRM_MSM depend on OF so that random test builds won't break. > > > > drivers/gpu/drm/display/Kconfig | 2 +- > > drivers/gpu/drm/msm/Kconfig | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > --- linux-6.11.orig/drivers/gpu/drm/display/Kconfig > > +++ linux-6.11/drivers/gpu/drm/display/Kconfig > > @@ -3,7 +3,7 @@ > > config DRM_DISPLAY_DP_AUX_BUS > > tristate > > depends on DRM > > - depends on OF || COMPILE_TEST > > + depends on OF > > > > config DRM_DISPLAY_HELPER > > tristate > > --- linux-6.11.orig/drivers/gpu/drm/msm/Kconfig > > +++ linux-6.11/drivers/gpu/drm/msm/Kconfig > > @@ -6,6 +6,7 @@ config DRM_MSM > > depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST > > depends on COMMON_CLK > > depends on IOMMU_SUPPORT > > + depends on OF =20 >=20 > Perhaps nobody landed this because you're missing the msm maintainers > as specified by `./scripts/get_maintainer.pl -f > drivers/gpu/drm/msm/Kconfig` ? I've added them here. It seems like > we'd at least need an Ack by those guys since this modified the > msm/Kconfig... You are right. The fix originally only touched drivers/gpu/drm/display/Kconfig and I forgot to update the maintainers list for v2 when drivers/gpu/drm/msm/Kconfig had to be modified as well. Thank you for noticing and getting the right people involved, this clearly made a difference :-) > FWIW I haven't spent massive time studying this, but what you have > here looks reasonable. I'm happy at least with this from a DP AUX bus > perspective: >=20 > Acked-by: Douglas Anderson >=20 > Presumably landing this via drm-misc makes the most sense after MSM > guys give it an Ack. Thanks, --=20 Jean Delvare SUSE L3 Support