From: John Garry <john.g.garry@oracle.com>
To: axboe@kernel.dk, brauner@kernel.org, djwong@kernel.org,
viro@zeniv.linux.org.uk, jack@suse.cz, dchinner@redhat.com,
hch@lst.de, cem@kernel.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hare@suse.de, martin.petersen@oracle.com,
catherine.hoang@oracle.com, mcgrof@kernel.org,
ritesh.list@gmail.com, ojaswin@linux.ibm.com,
John Garry <john.g.garry@oracle.com>
Subject: [PATCH v10 3/8] block: Add bdev atomic write limits helpers
Date: Sat, 19 Oct 2024 12:51:08 +0000 [thread overview]
Message-ID: <20241019125113.369994-4-john.g.garry@oracle.com> (raw)
In-Reply-To: <20241019125113.369994-1-john.g.garry@oracle.com>
Add helpers to get atomic write limits for a bdev, so that we don't access
request_queue helpers outside the block layer.
We check if the bdev can actually atomic write in these helpers, so we
can avoid users missing using this check.
Suggested-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
include/linux/blkdev.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 50c3b959da28..c2cc3c146d74 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1674,6 +1674,22 @@ static inline bool bdev_can_atomic_write(struct block_device *bdev)
return true;
}
+static inline unsigned int
+bdev_atomic_write_unit_min_bytes(struct block_device *bdev)
+{
+ if (!bdev_can_atomic_write(bdev))
+ return 0;
+ return queue_atomic_write_unit_min_bytes(bdev_get_queue(bdev));
+}
+
+static inline unsigned int
+bdev_atomic_write_unit_max_bytes(struct block_device *bdev)
+{
+ if (!bdev_can_atomic_write(bdev))
+ return 0;
+ return queue_atomic_write_unit_max_bytes(bdev_get_queue(bdev));
+}
+
#define DEFINE_IO_COMP_BATCH(name) struct io_comp_batch name = { }
#endif /* _LINUX_BLKDEV_H */
--
2.31.1
next prev parent reply other threads:[~2024-10-19 12:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 12:51 [PATCH v10 0/8] block atomic writes for xfs John Garry
2024-10-19 12:51 ` [PATCH v10 1/8] block/fs: Pass an iocb to generic_atomic_write_valid() John Garry
2024-10-19 12:51 ` [PATCH v10 2/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid() John Garry
2024-10-19 12:51 ` John Garry [this message]
2024-10-19 12:51 ` [PATCH v10 4/8] fs: Export generic_atomic_write_valid() John Garry
2024-10-19 12:51 ` [PATCH v10 5/8] fs: iomap: Atomic write support John Garry
2024-10-20 8:21 ` Ritesh Harjani
2024-10-20 11:21 ` John Garry
2024-10-20 11:37 ` Ritesh Harjani
2024-10-19 12:51 ` [PATCH v10 6/8] xfs: Support atomic write for statx John Garry
2024-10-19 12:51 ` [PATCH v10 7/8] xfs: Validate atomic writes John Garry
2024-10-20 9:44 ` Ritesh Harjani
2024-10-20 11:09 ` John Garry
2024-10-20 11:41 ` Ritesh Harjani
2024-10-19 12:51 ` [PATCH v10 8/8] xfs: Support setting FMODE_CAN_ATOMIC_WRITE John Garry
2024-10-19 22:49 ` (subset) [PATCH v10 0/8] block atomic writes for xfs Jens Axboe
2024-10-19 22:50 ` Jens Axboe
2024-10-23 12:42 ` John Garry
2024-10-23 12:50 ` Carlos Maiolino
2024-10-24 6:32 ` Ojaswin Mujoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241019125113.369994-4-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®