From: kernel test robot <lkp@intel.com>
To: Jean-Baptiste Maneyrol via B4 Relay
<devnull+jean-baptiste.maneyrol.tdk.com@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: oe-kbuild-all@lists.linux.dev, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Subject: Re: [PATCH] iio: invensense: fix multiple odr switch when FIFO is off
Date: Mon, 21 Oct 2024 02:30:28 +0800 [thread overview]
Message-ID: <202410210200.tPt6CQU4-lkp@intel.com> (raw)
In-Reply-To: <20241017-invn-inv-sensors-timestamp-fix-switch-fifo-off-v1-1-1bcfa70a747b@tdk.com>
Hi Jean-Baptiste,
kernel test robot noticed the following build warnings:
[auto build test WARNING on c3e9df514041ec6c46be83801b1891392f4522f7]
url: https://github.com/intel-lab-lkp/linux/commits/Jean-Baptiste-Maneyrol-via-B4-Relay/iio-invensense-fix-multiple-odr-switch-when-FIFO-is-off/20241017-220821
base: c3e9df514041ec6c46be83801b1891392f4522f7
patch link: https://lore.kernel.org/r/20241017-invn-inv-sensors-timestamp-fix-switch-fifo-off-v1-1-1bcfa70a747b%40tdk.com
patch subject: [PATCH] iio: invensense: fix multiple odr switch when FIFO is off
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20241021/202410210200.tPt6CQU4-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241021/202410210200.tPt6CQU4-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410210200.tPt6CQU4-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c: In function 'inv_icm42600_gyro_update_scan_mode':
>> drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c:103:39: warning: unused variable 'ts' [-Wunused-variable]
103 | struct inv_sensors_timestamp *ts = &gyro_st->ts;
| ^~
--
drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c: In function 'inv_icm42600_accel_update_scan_mode':
>> drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c:203:39: warning: unused variable 'ts' [-Wunused-variable]
203 | struct inv_sensors_timestamp *ts = &accel_st->ts;
| ^~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for GET_FREE_REGION
Depends on [n]: SPARSEMEM [=n]
Selected by [y]:
- RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]
vim +/ts +103 drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 96
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 97 /* enable gyroscope sensor and FIFO write */
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 98 static int inv_icm42600_gyro_update_scan_mode(struct iio_dev *indio_dev,
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 99 const unsigned long *scan_mask)
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 100 {
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 101 struct inv_icm42600_state *st = iio_device_get_drvdata(indio_dev);
a1432b5b4f4c44 Jean-Baptiste Maneyrol 2024-04-22 102 struct inv_icm42600_sensor_state *gyro_st = iio_priv(indio_dev);
a1432b5b4f4c44 Jean-Baptiste Maneyrol 2024-04-22 @103 struct inv_sensors_timestamp *ts = &gyro_st->ts;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 104 struct inv_icm42600_sensor_conf conf = INV_ICM42600_SENSOR_CONF_INIT;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 105 unsigned int fifo_en = 0;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 106 unsigned int sleep_gyro = 0;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 107 unsigned int sleep_temp = 0;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 108 unsigned int sleep;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 109 int ret;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 110
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 111 mutex_lock(&st->lock);
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 112
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 113 if (*scan_mask & INV_ICM42600_SCAN_MASK_TEMP) {
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 114 /* enable temp sensor */
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 115 ret = inv_icm42600_set_temp_conf(st, true, &sleep_temp);
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 116 if (ret)
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 117 goto out_unlock;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 118 fifo_en |= INV_ICM42600_SENSOR_TEMP;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 119 }
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 120
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 121 if (*scan_mask & INV_ICM42600_SCAN_MASK_GYRO_3AXIS) {
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 122 /* enable gyro sensor */
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 123 conf.mode = INV_ICM42600_SENSOR_MODE_LOW_NOISE;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 124 ret = inv_icm42600_set_gyro_conf(st, &conf, &sleep_gyro);
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 125 if (ret)
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 126 goto out_unlock;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 127 fifo_en |= INV_ICM42600_SENSOR_GYRO;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 128 }
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 129
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 130 /* update data FIFO write */
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 131 ret = inv_icm42600_buffer_set_fifo_en(st, fifo_en | st->fifo.en);
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 132
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 133 out_unlock:
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 134 mutex_unlock(&st->lock);
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 135 /* sleep maximum required time */
c788b9e56acd46 Bragatheswaran Manickavel 2023-10-27 136 sleep = max(sleep_gyro, sleep_temp);
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 137 if (sleep)
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 138 msleep(sleep);
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 139 return ret;
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 140 }
7f85e42a6c54c0 Jean-Baptiste Maneyrol 2020-06-22 141
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2024-10-20 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 14:06 Jean-Baptiste Maneyrol via B4 Relay
2024-10-19 14:39 ` Jonathan Cameron
2024-10-20 18:30 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202410210200.tPt6CQU4-lkp@intel.com \
--to=lkp@intel.com \
--cc=devnull+jean-baptiste.maneyrol.tdk.com@kernel.org \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®