From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0098D1CF7CC for ; Mon, 21 Oct 2024 06:41:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729492910; cv=none; b=PurNqmIrCIkqXGR5NZrZpdDDJJDgpfQvLdxWC5LtVZoGasYc/Jku0fIQKsigZw6yW33sEnxEceoO1gfqJMTthu0I/65P/mpsrAjoKHA903WjzHjxNCdlOVX9w510grysjzNuRTshjk9xGCs4bXMur/HAL1U3tDTymfwEpu6MPY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729492910; c=relaxed/simple; bh=hnFtsFX6EFYqg5HAO7XdkWjgtLfDDaotRvAd92AUo/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AYl+InndlB1v7nbsLN+NgBMip6rg5p57H95J9vLTmwGuFLjvrZ/rs1ymSZX+wJI2NHuC14g2PSPOe/ypL3LW/PbZZY2qL6mStho6xMIL7o81PTH0/Twt0kC/h957k/OxIqZegJythu4Tf7BUrWkmyEb81s2LUt01EAhpHXLa4YE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2m6c-0001kn-Fh; Mon, 21 Oct 2024 08:41:30 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t2m6b-000eHY-2n; Mon, 21 Oct 2024 08:41:29 +0200 Received: from mfe by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1t2m6b-005e3i-2U; Mon, 21 Oct 2024 08:41:29 +0200 Date: Mon, 21 Oct 2024 08:41:29 +0200 From: Marco Felsch To: Krzysztof Kozlowski Cc: POPESCU Catalin , Sherry Sun , Amitkumar Karwar , Neeraj Sanjay Kale , "marcel@holtmann.org" , "luiz.dentz@gmail.com" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "p.zabel@pengutronix.de" , "linux-bluetooth@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , GEO-CHHER-bsp-development Subject: Re: [PATCH 1/2] dt-bindings: net: bluetooth: nxp: add support for supply and reset Message-ID: <20241021064129.trchqa2oickna7pc@pengutronix.de> References: <20241004113557.2851060-1-catalin.popescu@leica-geosystems.com> <3fa35cd2-e52c-4873-8a7f-db459b016a97@kernel.org> <2b7f61a8-e91a-4b32-be1d-753a19e4d81f@leica-geosystems.com> <0d460226-4ea7-4a9b-a119-468343727996@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d460226-4ea7-4a9b-a119-468343727996@kernel.org> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On 24-10-07, Krzysztof Kozlowski wrote: > On 07/10/2024 14:58, POPESCU Catalin wrote: > >>>> > >>>> + vcc-supply: > >>>> + description: > >>>> + phandle of the regulator that provides the supply voltage. > >>>> + > >>>> + reset-gpios: > >>>> + description: > >>>> + Chip powerdown/reset signal (PDn). > >>>> + > >>> Hi Catalin, > >>> > >>> For NXP WIFI/BT chip, WIFI and BT share the one PDn pin, which means that both wifi and BT controller will be powered on and off at the same time. > >>> Taking the M.2 NXP WIFI/BT module as an example, pin56(W_DISABLE1) is connected to the WIFI/BT chip PDn pin, we has already controlled this pin in the corresponding PCIe/SDIO controller dts nodes. > >>> It is not clear to me what exactly pins for vcc-supply and reset-gpios you describing here. Can you help understand the corresponding pins on M.2 interface as an example? Thanks. > > > > Hi Sherry, > > > > Regulators and reset controls being refcounted, we can then implement > > powerup sequence in both bluetooth/wlan drivers and have the drivers > > operate independently. This way bluetooth driver would has no dependance > > on the wlan driver for : > > > > - its power supply > > > > - its reset pin (PDn) > > > > - its firmware (being downloaded as part of the combo firmware) > > > > For the wlan driver we use mmc power sequence to drive the chip reset > > pin and there's another patchset that adds support for reset control > > into the mmc pwrseq simple driver. > > > >> Please wrap your replies. > >> > >> It seems you need power sequencing just like Bartosz did for Qualcomm WCN. > > > > Hi Krzysztof, > > > > I'm not familiar with power sequencing, but looks like way more > > complicated than reset controls. So, why power sequencing is recommended > > here ? Is it b/c a supply is involved ? > > Based on earlier message: > > "For NXP WIFI/BT chip, WIFI and BT share the one PDn pin, which means > that both wifi and BT controller will be powered on and off at the same > time." > > but maybe that's not needed. No clue, I don't know the hardware. But be > carefully what you write in the bindings, because then it will be ABI. We noticed the new power-sequencing infrastructure which is part of 6.11 too but I don't think that this patch is wrong. The DT ABI won't break if we switch to the power-sequencing later on since the "reset-gpios" are not marked as required. So it is up to the driver to handle it either via a separate power-sequence driver or via "power-supply" and "reset-gpios" directly. Regards, Marco > Best regards, > Krzysztof > >