From: Nir Lichtman <nir@lichtman.org>
To: jason.wessel@windriver.com, daniel.thompson@linaro.org,
dianders@chromium.org, linux-kernel@vger.kernel.org
Subject: [PATCH] KDB: Fix missing argument in dmesg command usage help
Date: Tue, 22 Oct 2024 19:02:17 +0000 [thread overview]
Message-ID: <20241022190217.GA846685@lichtman.org> (raw)
Problem: Currently when running "help" in KDB, it shows the "dmesg" command
as having only a single argument, when in fact as can be seen in the
implementation of the command (kdb_dmesg) it accepts two arguments
Solution: Add the missing argument to the usage string of the "dmesg" command
Signed-off-by: Nir Lichtman <nir@lichtman.org>
---
kernel/debug/kdb/kdb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index f5f7d7fb5936..5f56ade565a6 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -2827,7 +2827,7 @@ static kdbtab_t maintab[] = {
#if defined(CONFIG_PRINTK)
{ .name = "dmesg",
.func = kdb_dmesg,
- .usage = "[lines]",
+ .usage = "[lines] [adjust]",
.help = "Display syslog buffer",
.flags = KDB_ENABLE_ALWAYS_SAFE,
},
--
2.39.2
next reply other threads:[~2024-10-22 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 19:02 Nir Lichtman [this message]
2024-10-25 22:37 ` Doug Anderson
2024-10-26 6:15 ` [PATCH v2] kdb: " Nir Lichtman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022190217.GA846685@lichtman.org \
--to=nir@lichtman.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®