mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linu Cherian <lcherian@marvell.com>
To: Simon Horman <horms@kernel.org>
Cc: <davem@davemloft.net>, <sgoutham@marvell.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<gakula@marvell.com>, <hkelam@marvell.com>, <sbhatta@marvell.com>,
	<jerinj@marvell.com>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH v3 net-next 2/2] octeontx2-af: Knobs for NPC default rule counters
Date: Thu, 24 Oct 2024 15:20:22 +0530	[thread overview]
Message-ID: <20241024095022.GB954957@hyd1403.caveonetworks.com> (raw)
In-Reply-To: <20241018120159.GJ1697@kernel.org>

Hi Simon,

On 2024-10-18 at 17:31:59, Simon Horman (horms@kernel.org) wrote:
> + Jiri
> 
> On Thu, Oct 17, 2024 at 02:12:44PM +0530, Linu Cherian wrote:
> > Add devlink knobs to enable/disable counters on NPC
> > default rule entries.
> > 
> > Sample command to enable default rule counters:
> > devlink dev param set <dev> name npc_def_rule_cntr value true cmode runtime
> > 
> > Sample command to read the counter:
> > cat /sys/kernel/debug/cn10k/npc/mcam_rules
> > 
> > Signed-off-by: Linu Cherian <lcherian@marvell.com>
> > ---
> > Changelog from v2:
> > Moved out the refactoring into separate patch. 
> > 
> >  .../net/ethernet/marvell/octeontx2/af/rvu.h   |  2 +
> >  .../marvell/octeontx2/af/rvu_devlink.c        | 32 +++++++++++++
> >  .../ethernet/marvell/octeontx2/af/rvu_npc.c   | 45 +++++++++++++++++++
> >  3 files changed, 79 insertions(+)
> 
> Hi Linu,
> 
> This looks like a good approach to me.
> However I think you also also need to add documentation for npc_def_rule_cntr
> to Documentation/networking/devlink/octeontx2.rst
> 
> Likewise, octeontx2.rst seems to be missing documentation for the existing
> AF parameters npc_mcam_high_zone_percent and nix_maxlf. I did not see
> if there are any more undocumented parameters for octeontx2 but I'd
> appreciate if you could do so.

Sure. Will add the documentation.

Thanks.


      reply	other threads:[~2024-10-24  9:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17  8:42 [PATCH v3 net-next 0/2] " Linu Cherian
2024-10-17  8:42 ` [PATCH v3 net-next 1/2] octeontx2-af: Refactor few NPC mcam APIs Linu Cherian
2024-10-18 11:58   ` Simon Horman
2024-10-17  8:42 ` [PATCH v3 net-next 2/2] octeontx2-af: Knobs for NPC default rule counters Linu Cherian
2024-10-18  3:09   ` Kalesh Anakkur Purayil
2024-10-24  9:49     ` Linu Cherian
2024-10-18 12:01   ` Simon Horman
2024-10-24  9:50     ` Linu Cherian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241024095022.GB954957@hyd1403.caveonetworks.com \
    --to=lcherian@marvell.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=horms@kernel.org \
    --cc=jerinj@marvell.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®