From: Peter Zijlstra <peterz@infradead.org>
To: Qi Xi <xiqi2@huawei.com>
Cc: kernel@openeuler.org, bobo.shaobowang@huawei.com,
mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, patrick.bellasi@arm.com, mkoutny@suse.com,
tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Fix compile warning about variable 'uclamp_mutex'
Date: Fri, 25 Oct 2024 09:32:13 +0200 [thread overview]
Message-ID: <20241025073213.GE36494@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241025034740.546570-1-xiqi2@huawei.com>
On Fri, Oct 25, 2024 at 11:47:40AM +0800, Qi Xi wrote:
> When build with CONFIG_UCLAMP_TASK && !CONFIG_UCLAMP_TASK_GROUP,
> the variable 'uclamp_mutex' is defined but not used:
>
> kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used [-Wunused-variable]
> 1361 | static DEFINE_MUTEX(uclamp_mutex);
>
> Fix this by only defining the variable uclamp_mutex when the
> CONFIG_UCLAMP_TASK_GROUP is enabled.
sigh.. I hate our CONFIG space :/
Perhaps add __maybe_unused like the other variables it sits right next
to instead of adding yet more #ifdef crud?
next prev parent reply other threads:[~2024-10-25 7:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 3:47 Qi Xi
2024-10-25 7:32 ` Peter Zijlstra [this message]
2024-10-25 22:08 ` kernel test robot
2024-10-25 22:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025073213.GE36494@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bobo.shaobowang@huawei.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kernel@openeuler.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=patrick.bellasi@arm.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=xiqi2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®