From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0C2E183CD4; Sat, 26 Oct 2024 07:13:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729926803; cv=none; b=X5iNKi3rURW6zvA5nruZmAAorIAlg1Lb6PjmzhXVttRVtK/TvWvQM2sMhLky4amfumaU4iieqcl6tM6mLric5newZ3EF50Ax5AjEix5h2SlgfVvvnEJQvBwW7BO954eIN86hg5JXa489FXa+aBlp7sGK5MFXavR0/eJV9pGvs8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729926803; c=relaxed/simple; bh=Q/sgAUVS6R7lQ6DyA99V3mGnHGzVphfOu8As7Kx0ljU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uWDzRqPY4JIHC7Mt/b78xCur/QYHSjG9T37Qf8F4ihGKopjYu9C41u4DlRhIV2lVge2Cfm1sYG32KPmZPkNfCOrmrqdDyhpIqwahmtPy+QZUvShsBCH6BXBqN0YApHjTKJPKPvNTUm6fJsaN2YYlh0ymZZVuaIxU9awPgQjczTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3028C4CEC6; Sat, 26 Oct 2024 07:13:18 +0000 (UTC) Date: Sat, 26 Oct 2024 03:13:14 -0400 From: Steven Rostedt To: Mathieu Desnoyers Cc: Jordan Rife , acme@kernel.org, alexander.shishkin@linux.intel.com, andrii.nakryiko@gmail.com, ast@kernel.org, bpf@vger.kernel.org, joel@joelfernandes.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, mhiramat@kernel.org, mingo@redhat.com, mjeanson@efficios.com, namhyung@kernel.org, paulmck@kernel.org, peterz@infradead.org, syzbot+b390c8062d8387b6272a@syzkaller.appspotmail.com, yhs@fb.com Subject: Re: [RFC PATCH v1] tracing: Fix syscall tracepoint use-after-free Message-ID: <20241026031314.0f53e7fa@rorschach.local.home> In-Reply-To: References: <20241025182149.500274-1-mathieu.desnoyers@efficios.com> <20241025190854.3030636-1-jrife@google.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 25 Oct 2024 15:38:48 -0400 Mathieu Desnoyers wrote: > > I'm curious if it might be better to add some field to struct > > tracepoint like "sleepable" rather than adding a special case here > > based on the name? Of course, if it's only ever going to be these > > two cases then maybe adding a new field doesn't make sense. > > I know Steven is reluctant to bloat the tracepoint struct because there > are lots of tracepoint instances (thousands). So for now I thought that > just comparing the name would be a good start. You are correct. I really trying to keep the footprint of tracepoints/events down. > > We can eventually go a different route as well: introduce a section just > to put the syscall tracepoints, and compare the struct tracepoint > pointers to the section begin/end range. But it's rather complex > for what should remain a simple fix. A separate section could work. -- Steve