From: Mario Limonciello <mario.limonciello@amd.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Maximilian Luz" <luzmaximilian@gmail.com>,
"Lee Chun-Yi" <jlee@suse.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D . Jones" <luke@ljones.dev>,
"Ike Panhc" <ike.pan@canonical.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Alexis Belmonte" <alexbelm48@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Ai Chao" <aichao@kylinos.cn>, "Gergo Koteles" <soyer@irl.hu>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
"open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER"
<platform-driver-x86@vger.kernel.org>,
"open list:THINKPAD ACPI EXTRAS DRIVER"
<ibm-acpi-devel@lists.sourceforge.net>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Matthew Schwartz" <matthew.schwartz@linux.dev>,
"Mario Limonciello" <mario.limonciello@amd.com>
Subject: [PATCH v2 10/15] ACPI: platform_profile: Only show profiles common for all handlers
Date: Sun, 27 Oct 2024 21:01:26 -0500 [thread overview]
Message-ID: <20241028020131.8031-11-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241028020131.8031-1-mario.limonciello@amd.com>
If multiple platform profile handlers have been registered, don't allow
switching to profiles unique to only one handler.
Tested-by: Matthew Schwartz <matthew.schwartz@linux.dev>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/acpi/platform_profile.c | 35 ++++++++++++++++++++++-----------
1 file changed, 24 insertions(+), 11 deletions(-)
diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index 5fee467614eac..a83842f05022b 100644
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -33,30 +33,43 @@ static bool platform_profile_is_registered(void)
return count > 0;
}
+/* expected to be called under mutex */
+static unsigned long platform_profile_get_choices(void)
+{
+ struct platform_profile_handler *handler;
+ unsigned long seen = 0;
+ int i;
+
+ list_for_each_entry(handler, &platform_profile_handler_list, list) {
+ for_each_set_bit(i, handler->choices, PLATFORM_PROFILE_LAST) {
+ if (seen & BIT(i))
+ continue;
+ seen |= BIT(i);
+ }
+ }
+
+ return seen;
+}
+
static ssize_t platform_profile_choices_show(struct device *dev,
struct device_attribute *attr,
char *buf)
{
+ unsigned long choices;
int len = 0;
- int err, i;
-
- err = mutex_lock_interruptible(&profile_lock);
- if (err)
- return err;
+ int i;
- if (!cur_profile) {
- mutex_unlock(&profile_lock);
- return -ENODEV;
- }
+ scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock)
+ choices = platform_profile_get_choices();
- for_each_set_bit(i, cur_profile->choices, PLATFORM_PROFILE_LAST) {
+ for_each_set_bit(i, &choices, PLATFORM_PROFILE_LAST) {
if (len == 0)
len += sysfs_emit_at(buf, len, "%s", profile_names[i]);
else
len += sysfs_emit_at(buf, len, " %s", profile_names[i]);
}
+
len += sysfs_emit_at(buf, len, "\n");
- mutex_unlock(&profile_lock);
return len;
}
--
2.43.0
next prev parent reply other threads:[~2024-10-28 2:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 2:01 [PATCH v2 00/15] Add support for binding ACPI platform profile to multiple drivers Mario Limonciello
2024-10-28 2:01 ` [PATCH v2 01/15] ACPI: platform-profile: Add a name member to handlers Mario Limonciello
2024-10-28 17:27 ` Maximilian Luz
2024-10-28 2:01 ` [PATCH v2 02/15] platform/surface: aggregator: Add platform handler pointer to device Mario Limonciello
2024-10-28 17:30 ` Maximilian Luz
2024-10-28 17:37 ` Mario Limonciello
2024-10-28 2:01 ` [PATCH v2 03/15] ACPI: platform_profile: Add platform handler argument to platform_profile_remove() Mario Limonciello
2024-10-28 17:31 ` Maximilian Luz
2024-10-28 2:01 ` [PATCH v2 04/15] ACPI: platform_profile: Add a list to platform profile handler Mario Limonciello
2024-10-28 2:01 ` [PATCH v2 05/15] ACPI: platform_profile: Move sanity check out of the mutex Mario Limonciello
2024-10-29 10:12 ` Ilpo Järvinen
2024-10-29 16:31 ` Mario Limonciello
2024-10-28 2:01 ` [PATCH v2 06/15] ACPI: platform_profile: Use guard(mutex) for register/unregister Mario Limonciello
2024-10-28 2:01 ` [PATCH v2 07/15] ACPI: platform_profile: Only remove group when no more handler registered Mario Limonciello
2024-10-28 2:01 ` [PATCH v2 08/15] ACPI: platform_profile: Require handlers to support balanced profile Mario Limonciello
2024-10-28 2:01 ` [PATCH v2 09/15] ACPI: platform_profile: Notify change events on register and unregister Mario Limonciello
2024-10-28 2:01 ` Mario Limonciello [this message]
2024-10-29 10:19 ` [PATCH v2 10/15] ACPI: platform_profile: Only show profiles common for all handlers Ilpo Järvinen
2024-10-28 2:01 ` [PATCH v2 11/15] ACPI: platform_profile: Set profile for all registered handlers Mario Limonciello
2024-10-29 10:22 ` Ilpo Järvinen
2024-10-29 16:36 ` Mario Limonciello
2024-10-29 16:50 ` Ilpo Järvinen
2024-10-29 16:51 ` Mario Limonciello
2024-10-28 2:01 ` [PATCH v2 12/15] ACPI: platform_profile: Make sure all profile handlers agree on profile Mario Limonciello
2024-10-29 10:43 ` Ilpo Järvinen
2024-10-28 2:01 ` [PATCH v2 13/15] ACPI: platform_profile: Check all profile handler to calculate next Mario Limonciello
2024-10-28 2:01 ` [PATCH v2 14/15] ACPI: platform_profile: Allow multiple handlers Mario Limonciello
2024-10-28 2:01 ` [PATCH v2 15/15] platform/x86/amd: pmf: Drop all quirks Mario Limonciello
2024-10-28 3:49 ` Shyam Sundar S K
2024-10-30 13:41 ` [PATCH v2 00/15] Add support for binding ACPI platform profile to multiple drivers Hans de Goede
2024-10-30 14:08 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028020131.8031-11-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=aichao@kylinos.cn \
--cc=alexbelm48@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ike.pan@canonical.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jlee@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=luzmaximilian@gmail.com \
--cc=matthew.schwartz@linux.dev \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=soyer@irl.hu \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®