mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Borislav Petkov" <bp@alien8.de>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: <x86@kernel.org>, "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	Perry Yuan <perry.yuan@amd.com>, <linux-kernel@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>
Subject: [PATCH v5 11/13] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification
Date: Sun, 27 Oct 2024 21:02:49 -0500	[thread overview]
Message-ID: <20241028020251.8085-12-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241028020251.8085-1-mario.limonciello@amd.com>

On designs that have workload classification, it's preferred that
the amd-hfi driver is used to provide hints to the scheduler of
which cores to use instead of the amd-pstate driver.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/cpufreq/amd-pstate.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 32ddbf37a9f0a..c60cc84866982 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -780,6 +780,12 @@ static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata)
 	/* user disabled or not detected */
 	if (!amd_pstate_prefcore)
 		return;
+	/* should use amd-hfi instead */
+	if (boot_cpu_has(X86_FEATURE_AMD_WORKLOAD_CLASS) &&
+	    IS_ENABLED(CONFIG_AMD_HFI)) {
+		amd_pstate_prefcore = false;
+		return;
+	}
 
 	cpudata->hw_prefcore = true;
 
-- 
2.43.0


  parent reply	other threads:[~2024-10-28  2:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28  2:02 [PATCH v5 00/13] Add support for AMD hardware feedback interface Mario Limonciello
2024-10-28  2:02 ` [PATCH v5 01/13] Documentation: x86: Add AMD Hardware Feedback Interface documentation Mario Limonciello
2024-10-28  2:02 ` [PATCH v5 02/13] MAINTAINERS: Add maintainer entry for AMD Hardware Feedback Driver Mario Limonciello
2024-10-28  2:02 ` [PATCH v5 03/13] x86/cpufeatures: add X86_FEATURE_AMD_WORKLOAD_CLASS feature bit Mario Limonciello
2024-10-28 13:01   ` [tip: x86/cpu] x86/cpufeatures: Add " tip-bot2 for Perry Yuan
2024-10-28  2:02 ` [PATCH v5 04/13] x86/msr-index: define AMD heterogeneous CPU related MSR Mario Limonciello
2024-10-28  2:02 ` [PATCH v5 05/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver Mario Limonciello
2024-10-28  5:52   ` Shyam Sundar S K
2024-10-28 16:13     ` Mario Limonciello
2024-10-29 19:16   ` Borislav Petkov
2024-10-28  2:02 ` [PATCH v5 06/13] platform/x86: hfi: parse CPU core ranking data from shared memory Mario Limonciello
2024-10-28  2:02 ` [PATCH v5 07/13] platform/x86: hfi: init per-cpu scores for each class Mario Limonciello
2024-10-28  2:02 ` [PATCH v5 08/13] platform/x86: hfi: add online and offline callback support Mario Limonciello
2024-10-28  2:02 ` [PATCH v5 09/13] platform/x86: hfi: add power management callback Mario Limonciello
2024-10-28  2:02 ` [PATCH v5 10/13] x86/process: Clear hardware feedback history for AMD processors Mario Limonciello
2024-10-29 19:48   ` Borislav Petkov
2024-10-28  2:02 ` Mario Limonciello [this message]
2024-10-28  7:56   ` [PATCH v5 11/13] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification Yuan, Perry
2024-10-28  2:02 ` [PATCH v5 12/13] platform/x86/amd: hfi: Set ITMT priority from ranking data Mario Limonciello
2024-10-28  2:02 ` [PATCH v5 13/13] platform/x86/amd: hfi: Add debugfs support Mario Limonciello
2024-10-29 19:20 ` [PATCH v5 00/13] Add support for AMD hardware feedback interface Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028020251.8085-12-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=bp@alien8.de \
    --cc=gautham.shenoy@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=perry.yuan@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®