mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: "André Almeida" <andrealmeid@igalia.com>,
	"Darren Hart" <dvhart@infradead.org>,
	"Davidlohr Bueso" <dave@stgolabs.net>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Juri Lelli" <juri.lelli@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Valentin Schneider" <vschneid@redhat.com>,
	"Waiman Long" <longman@redhat.com>
Subject: Re: [RFC v2 PATCH 0/4] futex: Add support task local hash maps.
Date: Mon, 28 Oct 2024 18:50:08 +0100	[thread overview]
Message-ID: <20241028175008.lgdGYYtp@linutronix.de> (raw)
In-Reply-To: <20241028121921.1264150-1-bigeasy@linutronix.de>

On 2024-10-28 13:13:54 [+0100], To linux-kernel@vger.kernel.org wrote:
> from time to time and I haven't seen it using the hashmap. Need to do
> more testing.

booted gnome and did a few things:
- Total allocations: 632
- tasks which never used their allocated futex hash: 2
  gpg-agent and systemd-journal
- Tasks which did not terminate within the measurement: 85
  This includes gpg-agent and systemd-journal
- Top5 users of the private hash:
  - firefox-esr-3786 used 215985
  - gnome-software-2343 used 121296
  - chromium-3369 used 65796
  - chromium-3209 used 34639
  - Isolated used 34211

This looks like we could attach the private futex hashmap directly on
fork instead of delaying it to the first usage.

Side note: If someone is waiting for a thread to exit via pthread_join()
then glibc uses here futex() with op 0x109. I would have expected a
private flag. 

Sebastian

  parent reply	other threads:[~2024-10-28 17:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 12:13 Sebastian Andrzej Siewior
2024-10-28 12:13 ` [RFC PATCH v2 1/4] futex: Create helper function to initialize a hash slot Sebastian Andrzej Siewior
2024-10-28 12:13 ` [RFC PATCH v2 2/4] futex: Add basic infrastructure for local task local hash Sebastian Andrzej Siewior
2024-10-28 12:13 ` [RFC PATCH v2 3/4] futex: Use the task local hashmap Sebastian Andrzej Siewior
2024-10-28 12:13 ` [RFC PATCH v2 4/4] futex: Allow automatic allocation of process wide futex hash Sebastian Andrzej Siewior
2024-10-28 17:50 ` Sebastian Andrzej Siewior [this message]
2024-10-29 11:10 ` [RFC v2 PATCH 0/4] futex: Add support task local hash maps Juri Lelli
2024-10-29 15:06   ` Sebastian Andrzej Siewior
2024-10-31 15:56 ` Sebastian Andrzej Siewior
2024-10-31 17:47   ` Sebastian Andrzej Siewior
2024-11-01 11:08     ` Sebastian Andrzej Siewior
2024-10-31 20:18   ` Waiman Long
2024-10-31 20:28   ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028175008.lgdGYYtp@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=andrealmeid@igalia.com \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®