From: Nir Lichtman <nir@lichtman.org>
To: Doug Anderson <dianders@chromium.org>
Cc: jason.wessel@windriver.com, daniel.thompson@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kdb: Fix breakpoint enable to be silent if already enabled
Date: Mon, 28 Oct 2024 19:26:24 +0000 [thread overview]
Message-ID: <20241028192624.GA918552@lichtman.org> (raw)
In-Reply-To: <CAD=FV=XP3WueSj9reLqsDm3-i3K0LMX7SJcf_Z=8E=3rD7E81g@mail.gmail.com>
On Mon, Oct 28, 2024 at 11:38:00AM -0700, Doug Anderson wrote:
>
> On Sun, Oct 27, 2024 at 1:47 PM Nir Lichtman <nir@lichtman.org> wrote:
> >
> > Fix the breakpoint enable command (be) to a logic that is inline with the
> > breakpoint disable command (bd) in which if the breakpoint is already in
> > an enabled state, do not print the message of enabled again to the user.
> >
>
> I don't ever use these commands (if I'm setting breakpoints them I'm
> using kgdb, not kdb), but this seems OK to me in general. I'm a little
> curious why you don't also make the "breakpoint clear" command
> consistent.
That's a good point I haven't looked at the bc logic,
will fix that as well and send a v2.
Thanks for the review,
Nir
>
> -Doug
next prev parent reply other threads:[~2024-10-28 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 20:47 Nir Lichtman
2024-10-28 18:38 ` Doug Anderson
2024-10-28 19:26 ` Nir Lichtman [this message]
2024-10-28 20:37 ` Nir Lichtman
2024-11-08 8:38 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028192624.GA918552@lichtman.org \
--to=nir@lichtman.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®