mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Ramona Alexandra Nechita <ramona.nechita@analog.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Nuno Sa <nuno.sa@analog.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: iio: adc: ad777x depends on CRC8
Date: Mon, 28 Oct 2024 20:04:42 +0000	[thread overview]
Message-ID: <20241028200442.4169b6f3@jic23-huawei> (raw)
In-Reply-To: <20241028162937.2171535-1-arnd@kernel.org>

On Mon, 28 Oct 2024 16:29:15 +0000
Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added driver fails to link when CONFIG_CRC8 is not set:
> 
> ld.lld-20: error: undefined symbol: crc8_populate_msb
> ld.lld-20: error: undefined symbol: crc8
> >>>               vmlinux.o:(ad7779_spi_read)  
> 
> Select this from Kconfig as we do for other drivers like it.
> 
> Fixes: cc20fa9e9ad4 ("drivers: iio: adc: add support for ad777x family")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Squashed into original patch.

Thanks!

Jonathan

> ---
>  drivers/iio/adc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index d8abe28eec89..849c90203071 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -290,6 +290,7 @@ config AD7768_1
>  config AD7779
>  	tristate "Analog Devices AD7779 ADC driver"
>  	depends on SPI
> +	select CRC8
>  	select IIO_BUFFER
>  	help
>  	  Say yes here to build support for Analog Devices AD777X family


      reply	other threads:[~2024-10-28 20:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 16:29 Arnd Bergmann
2024-10-28 20:04 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028200442.4169b6f3@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=ramona.nechita@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®