From: Jai Luthra <jai.luthra@ideasonboard.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Jai Luthra <jai.luthra@ideasonboard.com>,
David Plowman <david.plowman@raspberrypi.com>
Subject: [PATCH 1/3] media: i2c: imx219: Correct the minimum vblanking value
Date: Tue, 29 Oct 2024 14:27:35 +0530 [thread overview]
Message-ID: <20241029-imx219_fixes-v1-1-b45dc3658b4e@ideasonboard.com> (raw)
In-Reply-To: <20241029-imx219_fixes-v1-0-b45dc3658b4e@ideasonboard.com>
From: David Plowman <david.plowman@raspberrypi.com>
The datasheet for this sensor documents the minimum vblanking as being
32 lines. It does fix some problems with occasional black lines at the
bottom of images (tested on Raspberry Pi).
Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
drivers/media/i2c/imx219.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index e78a80b2bb2e455c857390b188c128b28c224778..f98aad74fe584a18e2fe7126f92bf294762a54e3 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -74,7 +74,7 @@
#define IMX219_REG_VTS CCI_REG16(0x0160)
#define IMX219_VTS_MAX 0xffff
-#define IMX219_VBLANK_MIN 4
+#define IMX219_VBLANK_MIN 32
/* HBLANK control - read only */
#define IMX219_PPL_DEFAULT 3448
--
2.47.0
next prev parent reply other threads:[~2024-10-29 8:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 8:57 [PATCH 0/3] media: i2c: imx219: Fixes for blanking and pixel rate Jai Luthra
2024-10-29 8:57 ` Jai Luthra [this message]
2024-11-04 8:33 ` [PATCH 1/3] media: i2c: imx219: Correct the minimum vblanking value Jacopo Mondi
2024-11-07 12:31 ` Dave Stevenson
2024-10-29 8:57 ` [PATCH 2/3] media: i2c: imx219: make HBLANK r/w to allow longer exposures Jai Luthra
2024-11-01 8:48 ` Sakari Ailus
2024-11-07 12:43 ` Dave Stevenson
2024-11-08 10:30 ` Sakari Ailus
2024-11-11 19:37 ` Dave Stevenson
2024-11-12 10:49 ` Sakari Ailus
2024-11-21 11:40 ` Jai Luthra
2024-11-04 9:20 ` Jacopo Mondi
2024-10-29 8:57 ` [PATCH 3/3] media: i2c: imx219: Scale the pixel rate for analog binning Jai Luthra
2024-11-04 9:33 ` Jacopo Mondi
2024-11-21 6:51 ` Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029-imx219_fixes-v1-1-b45dc3658b4e@ideasonboard.com \
--to=jai.luthra@ideasonboard.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=david.plowman@raspberrypi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®