From: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
To: dan.carpenter@linaro.org
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, philipp.g.hortmann@gmail.com,
rodrigo.gobbi.7@gmail.com, ~lkcamp/patches@lists.sr.ht
Subject: Re: staging: rtl8723bs: change remaining printk to proper api
Date: Tue, 29 Oct 2024 19:02:38 -0300 [thread overview]
Message-ID: <20241029220238.110407-1-rodrigo.gobbi.7@gmail.com> (raw)
In-Reply-To: <e12bc7eb-07ed-4bec-84f7-5b178ba802c2@stanley.mountain>
> Why are you pasing -DDBG_RX_SIGNAL_DISPLAY_RAW_DATA?
> ... But if there is some external document which says to enable it, and it's
> useful stuff then maybe we should keep it?
I've enabled this in an arbitrary way just to check the rtw_dump_raw_rssi_info()
because I was doing the debug replacement within the isolated code. Looking again,
I didn't find any documentation about this and the history of some files, the #ifdef
macro is very old...from 7years ago. We can remove this for sure.
> If it's not used, just delete it?
Ok, I'll do it in a next patch too.
> ...as you've looked at the
> initialization path and it's okay as you said.
Ok, I'll send a v4.
Tks again and regards!
next prev parent reply other threads:[~2024-10-29 22:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 23:11 [PATCH v3] " Rodrigo Gobbi
2024-10-24 7:28 ` Dan Carpenter
2024-10-24 22:55 ` Rodrigo Gobbi
2024-10-25 7:19 ` Dan Carpenter
2024-10-29 22:02 ` Rodrigo Gobbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-22 3:18 [PATCH v2] " Rodrigo Gobbi
2024-10-23 22:48 ` Rodrigo Gobbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029220238.110407-1-rodrigo.gobbi.7@gmail.com \
--to=rodrigo.gobbi.7@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®