mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yi Sun <yi.sun@unisoc.com>
To: <chao@kernel.org>, <jaegeuk@kernel.org>
Cc: <yi.sun@unisoc.com>, <sunyibuaa@gmail.com>,
	<linux-f2fs-devel@lists.sourceforge.net>,
	<linux-kernel@vger.kernel.org>, <niuzhiguo84@gmail.com>,
	<hao_hao.wang@unisoc.com>, <ke.wang@unisoc.com>
Subject: [PATCH v2 1/5] f2fs: blocks need to belong to the same segment when using update_sit_entry()
Date: Wed, 30 Oct 2024 18:31:32 +0800	[thread overview]
Message-ID: <20241030103136.2874140-2-yi.sun@unisoc.com> (raw)
In-Reply-To: <20241030103136.2874140-1-yi.sun@unisoc.com>

When using update_sit_entry() to release consecutive blocks,
ensure that the consecutive blocks belong to the same segment.
Because after update_sit_entry_for_realese(), @segno is still
in use in update_sit_entry().

Signed-off-by: Yi Sun <yi.sun@unisoc.com>
---
 fs/f2fs/segment.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index bb2fd98331cd..a5bd101c63a1 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -2424,6 +2424,10 @@ static void update_segment_mtime(struct f2fs_sb_info *sbi, block_t blkaddr,
 		SIT_I(sbi)->max_mtime = ctime;
 }
 
+/*
+ * NOTE: when updating multiple blocks at the same time, please ensure
+ * that the consecutive input blocks belong to the same segment.
+ */
 static int update_sit_entry_for_release(struct f2fs_sb_info *sbi, struct seg_entry *se,
 				block_t blkaddr, unsigned int offset, int del)
 {
@@ -2434,6 +2438,8 @@ static int update_sit_entry_for_release(struct f2fs_sb_info *sbi, struct seg_ent
 	int i;
 	int del_count = -del;
 
+	f2fs_bug_on(sbi, GET_SEGNO(sbi, blkaddr) != GET_SEGNO(sbi, blkaddr + del_count - 1));
+
 	for (i = 0; i < del_count; i++) {
 		exist = f2fs_test_and_clear_bit(offset + i, se->cur_valid_map);
 #ifdef CONFIG_F2FS_CHECK_FS
@@ -2476,6 +2482,11 @@ static int update_sit_entry_for_release(struct f2fs_sb_info *sbi, struct seg_ent
 	return del;
 }
 
+/*
+ * If releasing blocks, this function supports updating multiple consecutive blocks
+ * at one time, but please note that these consecutive blocks need to belong to the
+ * same segment.
+ */
 static void update_sit_entry(struct f2fs_sb_info *sbi, block_t blkaddr, int del)
 {
 	struct seg_entry *se;
-- 
2.25.1


  reply	other threads:[~2024-10-30 10:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 10:31 [PATCH v2 0/5] Speed up f2fs truncate Yi Sun
2024-10-30 10:31 ` Yi Sun [this message]
2024-10-31  7:19   ` [PATCH v2 1/5] f2fs: blocks need to belong to the same segment when using update_sit_entry() Chao Yu
2024-10-30 10:31 ` [PATCH v2 2/5] f2fs: expand f2fs_invalidate_compress_page() to f2fs_invalidate_compress_pages_range() Yi Sun
2024-10-31  7:26   ` Chao Yu
2024-10-31  9:02     ` yi sun
2024-10-30 10:31 ` [PATCH v2 3/5] f2fs: add parameter @len to f2fs_invalidate_internal_cache() Yi Sun
2024-10-31  7:27   ` Chao Yu
2024-10-30 10:31 ` [PATCH v2 4/5] f2fs: add parameter @len to f2fs_invalidate_blocks() Yi Sun
2024-10-30 17:00   ` [f2fs-dev] " Daeho Jeong
2024-10-31  3:00     ` yi sun
2024-10-31  9:10       ` Zhiguo Niu
2024-10-31 10:51         ` yi sun
2024-11-01  3:39     ` yi sun
2024-10-30 10:31 ` [PATCH v2 5/5] f2fs: Optimize f2fs_truncate_data_blocks_range() Yi Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030103136.2874140-2-yi.sun@unisoc.com \
    --to=yi.sun@unisoc.com \
    --cc=chao@kernel.org \
    --cc=hao_hao.wang@unisoc.com \
    --cc=jaegeuk@kernel.org \
    --cc=ke.wang@unisoc.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niuzhiguo84@gmail.com \
    --cc=sunyibuaa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®