From: "Pali Rohár" <pali@kernel.org>
To: Kurt Borja <kuurtb@gmail.com>
Cc: Dell.Client.Kernel@dell.com, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, w_armin@gmx.de
Subject: Re: [PATCH 2/2] dell-wmi-base: Handle Win-key Lock/Unlock events
Date: Wed, 30 Oct 2024 21:20:29 +0100 [thread overview]
Message-ID: <20241030202029.3ugz75wiautw6ewt@pali> (raw)
In-Reply-To: <hj6jurton7ll4i475cwcqvk6dzjjire2briawxmuemnliofpyo@kpjdxpwflekm>
On Wednesday 30 October 2024 17:11:40 Kurt Borja wrote:
> On Wed, Oct 30, 2024 at 07:34:36PM +0100, Pali Rohár wrote:
> > On Wednesday 30 October 2024 15:15:33 Kurt Borja wrote:
> > > Some Alienware devices have a key that locks/unlocks the Win-key. This
> >
> > Please specify (in comment / commit message) which devices. It would
> > help other developers in future to track for which device is this event
> > needed.
>
> I will!
>
> >
> > > key triggers a WMI event that should be ignored, as it's handled
> > > internally by the firmware.
> >
> > Can be this handling in FW ignored? So OS can use this key for any other
> > functionality?
>
> Probably not. FW locks the Win-key regardless of how the event is
> handled.
>
> >
> > Anyway, what is that Win-key and its lock?
>
> Win-key is the LEFTMETA key and the lock key is the RIGHTMETA key.
Ok, thanks for info.
So if the firmware handles and process RIGHTMETA key, it means that the
RIGHTMETA key is not usable for generic purposes on this machine?
> >
> > > Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> > > ---
> > > drivers/platform/x86/dell/dell-wmi-base.c | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> > > index 502783a7a..37fc0371a 100644
> > > --- a/drivers/platform/x86/dell/dell-wmi-base.c
> > > +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> > > @@ -80,6 +80,12 @@ static const struct dmi_system_id dell_wmi_smbios_list[] __initconst = {
> > > static const struct key_entry dell_wmi_keymap_type_0000[] = {
> > > { KE_IGNORE, 0x003a, { KEY_CAPSLOCK } },
> > >
> > > + /* Win-key Lock */
> > > + { KE_IGNORE, 0xe000, {KEY_RESERVED} },
> >
> > nit: code style: spaces around KEY_RESERVED.
>
> I will fix it.
>
> >
> > Is not there some better constant for this KEY_*?
>
> We could assign it KEY_RIGHTMETA.
Just to note that if the key is marked with KE_IGNORE, its value is not
used. But for documentation purposes it is a good idea to have written
there something other than KEY_RESERVED -- if it is possible.
For example it can be useful if somebody in future figure out how to
turn off processing of this key in firmware...
> >
> > > +
> > > + /* Win-key Unlock */
> > > + { KE_IGNORE, 0xe001, {KEY_RESERVED} },
> > > +
> > > /* Key code is followed by brightness level */
> > > { KE_KEY, 0xe005, { KEY_BRIGHTNESSDOWN } },
> > > { KE_KEY, 0xe006, { KEY_BRIGHTNESSUP } },
> > > --
> > > 2.47.0
> > >
next prev parent reply other threads:[~2024-10-30 20:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 18:12 [PATCH 1/2] dell-smbios-base: Extends support to Alienware products Kurt Borja
2024-10-30 18:15 ` [PATCH 2/2] dell-wmi-base: Handle Win-key Lock/Unlock events Kurt Borja
2024-10-30 18:34 ` Pali Rohár
2024-10-30 20:11 ` Kurt Borja
2024-10-30 20:20 ` Pali Rohár [this message]
2024-10-30 20:37 ` Kurt Borja
2024-10-30 20:40 ` Pali Rohár
2024-10-30 18:26 ` [PATCH 1/2] dell-smbios-base: Extends support to Alienware products Pali Rohár
2024-10-30 20:01 ` Kurt Borja
2024-10-30 20:07 ` Pali Rohár
2024-10-30 20:33 ` Kurt Borja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030202029.3ugz75wiautw6ewt@pali \
--to=pali@kernel.org \
--cc=Dell.Client.Kernel@dell.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=w_armin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®