From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rosen Penev" <rosenp@gmail.com>,
"Breno Leitao" <leitao@debian.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net-next 08/12] net: ibm: emac: zmii: use devm for mutex_init
Date: Wed, 30 Oct 2024 13:37:23 -0700 [thread overview]
Message-ID: <20241030203727.6039-9-rosenp@gmail.com> (raw)
In-Reply-To: <20241030203727.6039-1-rosenp@gmail.com>
It seems that since inception, this driver never called mutex_destroy in
_remove. Use devm to handle this automatically.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/ibm/emac/zmii.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/emac/zmii.c b/drivers/net/ethernet/ibm/emac/zmii.c
index e9097b9ceb3d..cb57c960b34d 100644
--- a/drivers/net/ethernet/ibm/emac/zmii.c
+++ b/drivers/net/ethernet/ibm/emac/zmii.c
@@ -235,13 +235,17 @@ static int zmii_probe(struct platform_device *ofdev)
struct device_node *np = ofdev->dev.of_node;
struct zmii_instance *dev;
struct resource regs;
+ int err;
dev = devm_kzalloc(&ofdev->dev, sizeof(struct zmii_instance),
GFP_KERNEL);
if (!dev)
return -ENOMEM;
- mutex_init(&dev->lock);
+ err = devm_mutex_init(&ofdev->dev, &dev->lock);
+ if (err)
+ return err;
+
dev->ofdev = ofdev;
dev->mode = PHY_INTERFACE_MODE_NA;
--
2.47.0
next prev parent reply other threads:[~2024-10-30 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 20:37 [PATCH net-next 00/12] ibm: emac: cleanup modules to use devm Rosen Penev
2024-10-30 20:37 ` [PATCH net-next 01/12] net: ibm: emac: tah: use devm for kzalloc Rosen Penev
2024-10-30 20:37 ` [PATCH net-next 02/12] net: ibm: emac: tah: use devm for mutex_init Rosen Penev
2024-10-30 20:37 ` [PATCH net-next 03/12] net: ibm: emac: tah: devm_platform_get_resources Rosen Penev
2024-10-30 20:37 ` [PATCH net-next 04/12] net: ibm: emac: rgmii: use devm for kzalloc Rosen Penev
2024-10-30 20:37 ` [PATCH net-next 05/12] net: ibm: emac: rgmii: use devm for mutex_init Rosen Penev
2024-10-30 20:37 ` [PATCH net-next 06/12] net: ibm: emac: rgmii: devm_platform_get_resource Rosen Penev
2024-10-30 20:37 ` [PATCH net-next 07/12] net: ibm: emac: zmii: use devm for kzalloc Rosen Penev
2024-10-30 20:37 ` Rosen Penev [this message]
2024-10-30 20:37 ` [PATCH net-next 09/12] net: ibm: emac: zmii: devm_platform_get_resource Rosen Penev
2024-10-30 20:37 ` [PATCH net-next 10/12] net: ibm: emac: mal: use devm for kzalloc Rosen Penev
2024-10-30 20:37 ` [PATCH net-next 11/12] net: ibm: emac: mal: use devm for request_irq Rosen Penev
2024-10-30 20:37 ` [PATCH net-next 12/12] net: ibm: emac: mal: move irq maps down Rosen Penev
2024-11-03 22:50 ` [PATCH net-next 00/12] ibm: emac: cleanup modules to use devm patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030203727.6039-9-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®