mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>,
	"Maximilian Luz" <luzmaximilian@gmail.com>,
	"Lee Chun-Yi" <jlee@suse.com>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Luke D . Jones" <luke@ljones.dev>,
	"Ike Panhc" <ike.pan@canonical.com>,
	"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
	"Alexis Belmonte" <alexbelm48@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Ai Chao" <aichao@kylinos.cn>, "Gergo Koteles" <soyer@irl.hu>,
	"open list" <linux-kernel@vger.kernel.org>,
	"open list:ACPI" <linux-acpi@vger.kernel.org>,
	"open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER"
	<platform-driver-x86@vger.kernel.org>,
	"open list:THINKPAD ACPI EXTRAS DRIVER"
	<ibm-acpi-devel@lists.sourceforge.net>,
	"Mark Pearson" <mpearson-lenovo@squebb.ca>,
	"Matthew Schwartz" <matthew.schwartz@linux.dev>,
	"Mario Limonciello" <mario.limonciello@amd.com>
Subject: [PATCH v3 21/22] ACPI: platform_profile: Allow multiple handlers
Date: Wed, 30 Oct 2024 23:09:51 -0500	[thread overview]
Message-ID: <20241031040952.109057-22-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241031040952.109057-1-mario.limonciello@amd.com>

Multiple drivers may attempt to register platform profile handlers,
but only one may be registered and the behavior is non-deterministic
for which one wins.  It's mostly controlled by probing order.

This can be problematic if one driver changes CPU settings and another
driver notifies the EC for changing fan curves.

Modify the ACPI platform profile handler to let multiple drivers
register platform profile handlers and abstract this detail from userspace.

To avoid undefined behaviors only offer profiles that are commonly
advertised across multiple handlers.

If any problems occur when changing profiles for any driver, then revert
back to the balanced profile, which is now required.

Tested-by: Matthew Schwartz <matthew.schwartz@linux.dev>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/acpi/platform_profile.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index 1cc8182930dde..a845524a248b9 100644
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -9,7 +9,6 @@
 #include <linux/platform_profile.h>
 #include <linux/sysfs.h>
 
-static struct platform_profile_handler *cur_profile;
 static LIST_HEAD(platform_profile_handler_list);
 static DEFINE_MUTEX(profile_lock);
 
@@ -212,7 +211,8 @@ static const struct attribute_group platform_profile_group = {
 
 void platform_profile_notify(void)
 {
-	if (!cur_profile)
+	guard(mutex)(&profile_lock);
+	if (!platform_profile_is_registered())
 		return;
 	sysfs_notify(acpi_kobj, NULL, "platform_profile");
 }
@@ -280,9 +280,6 @@ int platform_profile_register(struct platform_profile_handler *pprof)
 	}
 
 	guard(mutex)(&profile_lock);
-	/* We can only have one active profile */
-	if (cur_profile)
-		return -EEXIST;
 
 	registered = platform_profile_is_registered();
 	if (!registered) {
@@ -313,7 +310,6 @@ int platform_profile_register(struct platform_profile_handler *pprof)
 	list_add_tail(&pprof->list, &platform_profile_handler_list);
 	sysfs_notify(acpi_kobj, NULL, "platform_profile");
 
-	cur_profile = pprof;
 	return 0;
 
 cleanup_device:
@@ -336,8 +332,6 @@ int platform_profile_remove(struct platform_profile_handler *pprof)
 
 	list_del(&pprof->list);
 
-	cur_profile = NULL;
-
 	sysfs_notify(acpi_kobj, NULL, "platform_profile");
 
 	sysfs_remove_group(&pprof->class_dev->kobj, &platform_profile_group);
-- 
2.43.0


  parent reply	other threads:[~2024-10-31  4:11 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31  4:09 [PATCH v3 00/22] Add support for binding ACPI platform profile to multiple drivers Mario Limonciello
2024-10-31  4:09 ` [PATCH v3 01/22] ACPI: platform-profile: Add a name member to handlers Mario Limonciello
2024-10-31  4:09 ` [PATCH v3 02/22] platform/x86/dell: dell-pc: Create platform device Mario Limonciello
2024-10-31  4:09 ` [PATCH v3 03/22] ACPI: platform_profile: Add device pointer into platform profile handler Mario Limonciello
2024-11-02  2:13   ` Mark Pearson
2024-11-02  9:56   ` Maximilian Luz
2024-10-31  4:09 ` [PATCH v3 04/22] ACPI: platform_profile: Add platform handler argument to platform_profile_remove() Mario Limonciello
2024-10-31  4:09 ` [PATCH v3 05/22] ACPI: platform_profile: Add a list to platform profile handler Mario Limonciello
2024-10-31  4:09 ` [PATCH v3 06/22] ACPI: platform_profile: Move sanity check out of the mutex Mario Limonciello
2024-11-02  2:13   ` Mark Pearson
2024-10-31  4:09 ` [PATCH v3 07/22] ACPI: platform_profile: Use guard(mutex) for register/unregister Mario Limonciello
2024-10-31 10:16   ` Ilpo Järvinen
2024-10-31  4:09 ` [PATCH v3 08/22] ACPI: platform_profile: Use `scoped_cond_guard` for platform_profile_choices_show() Mario Limonciello
2024-10-31  4:09 ` [PATCH v3 09/22] ACPI: platform_profile: Use `scoped_cond_guard` for platform_profile_show() Mario Limonciello
2024-10-31  4:09 ` [PATCH v3 10/22] " Mario Limonciello
2024-10-31 10:15   ` Ilpo Järvinen
2024-10-31 13:16     ` Mario Limonciello
2024-10-31  4:09 ` [PATCH v3 11/22] ACPI: platform_profile: Use `scoped_cond_guard` for platform_profile_cycle() Mario Limonciello
2024-11-02  2:14   ` Mark Pearson
2024-10-31  4:09 ` [PATCH v3 12/22] ACPI: platform_profile: Only remove group when no more handler registered Mario Limonciello
2024-10-31  4:09 ` [PATCH v3 13/22] ACPI: platform_profile: Require handlers to support balanced profile Mario Limonciello
2024-10-31 20:39   ` Armin Wolf
2024-10-31 20:43     ` Mario Limonciello
2024-10-31 21:01       ` Armin Wolf
2024-10-31  4:09 ` [PATCH v3 14/22] ACPI: platform_profile: Notify change events on register and unregister Mario Limonciello
2024-11-02  2:14   ` Mark Pearson
2024-10-31  4:09 ` [PATCH v3 15/22] ACPI: platform_profile: Only show profiles common for all handlers Mario Limonciello
2024-11-02  2:15   ` Mark Pearson
2024-10-31  4:09 ` [PATCH v3 16/22] ACPI: platform_profile: Set profile for all registered handlers Mario Limonciello
2024-10-31 10:25   ` Ilpo Järvinen
2024-10-31 13:18     ` Mario Limonciello
2024-10-31 14:37       ` Ilpo Järvinen
2024-10-31 14:40         ` Mario Limonciello
2024-10-31  4:09 ` [PATCH v3 17/22] ACPI: platform_profile: Add concept of a "custom" profile Mario Limonciello
2024-11-02  2:15   ` Mark Pearson
2024-10-31  4:09 ` [PATCH v3 18/22] ACPI: platform_profile: Make sure all profile handlers agree on profile Mario Limonciello
2024-11-02  2:15   ` Mark Pearson
2024-10-31  4:09 ` [PATCH v3 19/22] ACPI: platform_profile: Check all profile handler to calculate next Mario Limonciello
2024-10-31 10:40   ` Ilpo Järvinen
2024-11-02  2:15   ` Mark Pearson
2024-10-31  4:09 ` [PATCH v3 20/22] ACPI: platform_profile: Register class device for platform profile handlers Mario Limonciello
2024-10-31 20:55   ` Armin Wolf
2024-10-31 21:54     ` Mario Limonciello
2024-11-01  1:54       ` Armin Wolf
2024-11-02  2:13     ` Mark Pearson
2024-11-02 23:46       ` Armin Wolf
2024-11-01 14:22   ` kernel test robot
2024-11-01 15:45   ` kernel test robot
2024-10-31  4:09 ` Mario Limonciello [this message]
2024-11-02  2:15   ` [PATCH v3 21/22] ACPI: platform_profile: Allow multiple handlers Mark Pearson
2024-10-31  4:09 ` [PATCH v3 22/22] platform/x86/amd: pmf: Drop all quirks Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241031040952.109057-22-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=aichao@kylinos.cn \
    --cc=alexbelm48@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ike.pan@canonical.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jlee@suse.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=luzmaximilian@gmail.com \
    --cc=matthew.schwartz@linux.dev \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=soyer@irl.hu \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®