From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Lucas Stach <l.stach@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Sui Jingfeng <sui.jingfeng@linux.dev>
Subject: [etnaviv-next v3] drm/etnaviv: Print an error message if inserting IOVA range fails
Date: Thu, 31 Oct 2024 23:56:16 +0800 [thread overview]
Message-ID: <20241031155616.2451084-1-sui.jingfeng@linux.dev> (raw)
Print an error message to help debug when such an error happens,
since there meight have other CPU page size & GPU page size combinations.
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
---
v3:
- Pick up tags and resend.
- Slightly improve commit message.
---
drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
index 7e065b3723cf..47b6242e24a0 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
@@ -298,8 +298,12 @@ int etnaviv_iommu_map_gem(struct etnaviv_iommu_context *context,
ret = etnaviv_iommu_insert_exact(context, node, etnaviv_obj->size, va);
else
ret = etnaviv_iommu_find_iova(context, node, etnaviv_obj->size);
- if (ret < 0)
+ if (ret) {
+ dev_err_ratelimited(context->global->dev,
+ "Insert iova failed: 0x%llx(0x%x)\n",
+ va, etnaviv_obj->size);
goto unlock;
+ }
mapping->iova = node->start;
ret = etnaviv_iommu_map(context, node->start, etnaviv_obj->size, sgt,
--
2.34.1
reply other threads:[~2024-10-31 15:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031155616.2451084-1-sui.jingfeng@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=airlied@gmail.com \
--cc=christian.gmeiner@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®