From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35AF7171BB for ; Fri, 1 Nov 2024 00:25:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730420716; cv=none; b=em2waeyCrTXx8EgXKset+kIVU6+eayHA5oePomUauIxZOcsPcVSMEkYer/DjhrZEgGZvg2pykPC0NR0qd5dBRETdUwzJTLHEp1H9KwJLdfgdNAmrUUMQnPRmeMDom2W3L+eUDsKBRYY4+/IftdD+A+vu/i67KgjG8sv9d/K2eik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730420716; c=relaxed/simple; bh=2jBD0sl9KT2Qp/EDHaop9tjjGL1eeuSLdTvEobSlC2o=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=kBYFYkBEYDS8h7O4iUjRc68HveIF1jR6mtlxphWvm+YiFvTzhxlaOsvOC25CI+brv59jn6ci++0gU4EGu6uqqhXE6tFFTv9z2XWA5xdRt8pNMmGOXRfCjP0sZGGTkMushiA/GXm1RV5RQTVngyZO2Huvt+QC7bpjRzAR5yUrD+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=snKae7bO; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="snKae7bO" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-539f72c8fc1so2460952e87.1 for ; Thu, 31 Oct 2024 17:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730420708; x=1731025508; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=LPWl0EhL6KI0Pyg9VIPJdMDq/EwgacWWrQ4ao+PcFsU=; b=snKae7bOxG0SzgOj9xyocUMWz1/S+p+gtvRT0AGd5SzN2qOK/dcG0J+IfVQfazA7WT IjZRhU2R0F/GzhyF3hN6hE4FhDOluIaelqeXc9t/soVZAUOI3JFinB6OAr9UWpO9ipWF l5SGJTuSnw8GWMyzFSd4KtovA4+QfqiP7nQgZia3SCTFhpFYkfWEwu606rFwn9NIE8hR 9iSXOk/dLzS+QtavXHxKvjN1S4wTj29gakDwPVmWVm4mazk+EibLlvLwog5aHncl46wO +j+v6MqTwIJ2uuPBC9MTATV+IKCWzPtuJnfpjKejTfbRQhxSDu14aTBZg1tELlXa4LJs ryIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730420708; x=1731025508; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LPWl0EhL6KI0Pyg9VIPJdMDq/EwgacWWrQ4ao+PcFsU=; b=doycUEj+5uxFzTkAHu4ZcHw0G7bFqf5PnDRQ7Nv/z3sWV7t173NRf0OEZC5lIxmIIU 6PiEogjRZx39qX6UhHS3NMqp91Q4UJzFQSSH23j9nd5vzR3OwyWRYUHb9ybYrMa2pN5X PXSFd+VcFELF+FmZfHVJ34bfQf3ZN6TpLwcl4PcCFdXfNs4eOv1YVriIzHaO7Eye+OMD uueDQ+3iWgB9eVKWGl7T3KEfFxnFbeII5nXvndDrZh8rbYWVUiTQrff3tjrNI4ASy0Gy M+qEEFpJgIDndhciWbvfJkDAf2E25gdxy3jLtj1+/KUyAg7kj05FSHbJ53yIdB+2cdJu kOxg== X-Forwarded-Encrypted: i=1; AJvYcCWavY+CdAQ7bXaTujbo6ZjH9yeUb7xlDkJgRr6ZqsWBNYujg0BtLJQrlKfqzqqkFd6DEog7lTuQkSQPRXg=@vger.kernel.org X-Gm-Message-State: AOJu0YwwEXhpLJTcLsiLP3vd8LojhqZtZ9Nr9N8sQKjY5y/wFNNWkWvX xs0+hjH7EVEPRUQdmj4iRWhOIxpSyQ1JrvViRfAsDcMHNjF+OmTjQFTMIc6EU74= X-Google-Smtp-Source: AGHT+IGzQdvR9n9N5nsIKtK9Qhx1FHQRUlJs7sw78abE6mZx2jxTi9cQ9DuYKZQZysqMNCy1gebATA== X-Received: by 2002:a05:6512:130f:b0:539:fbf7:38d1 with SMTP id 2adb3069b0e04-53b7ecd5970mr5312335e87.2.1730420708098; Thu, 31 Oct 2024 17:25:08 -0700 (PDT) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53c7bcce489sm371153e87.127.2024.10.31.17.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 17:25:07 -0700 (PDT) From: Dmitry Baryshkov Subject: [PATCH v2 0/6] drm/display: hdmi: add drm_hdmi_connector_mode_valid() Date: Fri, 01 Nov 2024 02:25:03 +0200 Message-Id: <20241101-hdmi-mode-valid-v2-0-a6478fd20fa6@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAN8fJGcC/3WNQQ7CIBBFr9LM2jFAUNGV9zBdEJiWSVowYIim4 e5i9y7fS/77GxTKTAVuwwaZKhdOsYM6DOCCjTMh+86ghNJSSIPBr4xr8oTVLuzRWnJaK3MS0kF fPTNN/N6Lj7Fz4PJK+bMfVPmz/1tVosAz6aslbYScLveFo83pmPIMY2vtCz+UD4OvAAAA X-Change-ID: 20241018-hdmi-mode-valid-aaec4428501c To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1994; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=2jBD0sl9KT2Qp/EDHaop9tjjGL1eeuSLdTvEobSlC2o=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnJB/hvEH2fbu10syN0kMJjljMx5W/ESzQUVOsw TIFkNSzP9aJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZyQf4QAKCRCLPIo+Aiko 1aH1B/wOZhTNhYOTk6Qqu7BncZn5jLCtS2Yc3ZKRtmLY2SPPxUlQSH3BJufcG08aT9tcaRJtvzH dLiSvu7kKRrptx8XXTTAowIe+PjKHNcvJt6f/DS+Xq09ujGERYNsYJKUmENNauW7tCtInm5iWTi FP0Pg2y/9Ekcqir7E+h+S+AvNfXY2PP8cS9krf3a7/mfkI9ZQ08L+YSu7emXZzSvoK8lFP2Xb8q zKLnQq9TISsrTJHx/nO3Ex/qPCXDdG0yzSTjb/7JmE5it/eN5z2GMuhJxiw7KOzsWYVeKpTf13D dJTT2kruCf1H+YrwsP3YdsqRpFJvq9psMttgI+8Wl1fHfwEO X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Several HDMI drivers have common code pice in the .mode_valid function that validates RGB / 8bpc rate using the TMDS char rate callbacks. Move this code piece to the common helper and remove the need to perform this check manually. In case of DRM_BRIDGE_OP_HDMI bridges, they can skip the check in favour of performing it in drm_bridge_connector. Signed-off-by: Dmitry Baryshkov --- Changes in v2: - Switched drm_hdmi_connector_mode_valid() to use common helper (ex-hdmi_clock_valid()) (Maxime) - Added simple unit tests for drm_hdmi_connector_mode_valid(). - Link to v1: https://lore.kernel.org/r/20241018-hdmi-mode-valid-v1-0-6e49ae4801f7@linaro.org --- Dmitry Baryshkov (6): drm/display: hdmi: add generic mode_valid helper drm/sun4i: use drm_hdmi_connector_mode_valid() drm/vc4: use drm_hdmi_connector_mode_valid() drm/display: bridge_connector: use drm_bridge_connector_mode_valid() drm/bridge: lontium-lt9611: drop TMDS char rate check in mode_valid drm/bridge: dw-hdmi-qp: replace mode_valid with tmds_char_rate drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 12 +- drivers/gpu/drm/display/drm_bridge_connector.c | 16 +- drivers/gpu/drm/display/drm_hdmi_helper.c | 45 ++++++ drivers/gpu/drm/display/drm_hdmi_helper_internal.h | 11 ++ drivers/gpu/drm/display/drm_hdmi_state_helper.c | 26 +--- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 12 +- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 168 ++++++++++++++++++++- drivers/gpu/drm/vc4/vc4_hdmi.c | 4 +- include/drm/display/drm_hdmi_helper.h | 4 + 10 files changed, 252 insertions(+), 50 deletions(-) --- base-commit: 623b1e4d2eace0958996995f9f88cb659a6f69dd change-id: 20241018-hdmi-mode-valid-aaec4428501c Best regards, -- Dmitry Baryshkov