mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Saravana Kannan <saravanak@google.com>
Subject: Re: [PATCH] driver core: constify devlink class
Date: Fri, 1 Nov 2024 01:39:49 +0100	[thread overview]
Message-ID: <2024110105-uptight-overdress-1f25@gregkh> (raw)
In-Reply-To: <CAMRc=MdxxfhXw8JP9We5Ty_gpiU+G9mUD2mgfPoQm8gaE=CX=A@mail.gmail.com>

On Thu, Oct 31, 2024 at 01:31:43PM +0100, Bartosz Golaszewski wrote:
> On Thu, Oct 24, 2024 at 9:54 PM Saravana Kannan <saravanak@google.com> wrote:
> >
> > On Thu, Oct 24, 2024 at 12:45 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> > >
> > > On Mon, Oct 14, 2024 at 2:28 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > >
> > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > >
> > > > The devlink class object is never modified and can be made constant.
> > > >
> > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > Acked-by: Rafael J. Wysocki <rafael@kernel.org>
> >
> > Acked-by: Saravana Kannan <saravanak@google.com>
> >
> > -Saravana
> >
> > >
> > > > ---
> > > >  drivers/base/core.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > > > index a84a7b952cfd..0e618d675792 100644
> > > > --- a/drivers/base/core.c
> > > > +++ b/drivers/base/core.c
> > > > @@ -553,7 +553,7 @@ void device_link_wait_removal(void)
> > > >  }
> > > >  EXPORT_SYMBOL_GPL(device_link_wait_removal);
> > > >
> > > > -static struct class devlink_class = {
> > > > +static const struct class devlink_class = {
> > > >         .name = "devlink",
> > > >         .dev_groups = devlink_groups,
> > > >         .dev_release = devlink_dev_release,
> > > > --
> > > > 2.43.0
> > > >
> 
> Greg, can you pick this one up please?

I will, give me time for trivial stuff like this please, lots of travel
and "other" things happening right now (i.e. my INBOX is trashed.)

Will be able to hopefully catch up by the end of next week if all goes
well...

thanks,

greg k-h

      reply	other threads:[~2024-11-01  0:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14 12:28 Bartosz Golaszewski
2024-10-24 19:08 ` Bartosz Golaszewski
2024-10-24 19:45 ` Rafael J. Wysocki
2024-10-24 19:54   ` Saravana Kannan
2024-10-31 12:31     ` Bartosz Golaszewski
2024-11-01  0:39       ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024110105-uptight-overdress-1f25@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®