From: Lance Yang <ioworker0@gmail.com>
To: akpm@linux-foundation.org
Cc: ioworker0@gmail.com, 21cnbao@gmail.com,
baolin.wang@linux.alibaba.com, cunhuang@tencent.com,
david@redhat.com, dj456119@gmail.com, j.granados@samsung.com,
joel.granados@kernel.org, jsiddle@redhat.com,
kent.overstreet@linux.dev, leonylgao@tencent.com,
libang.li@antgroup.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux@weissschuh.net, mingzhe.yang@ly.com,
ryan.roberts@arm.com, ziy@nvidia.com
Subject: Re: [PATCH v2 1/2] hung_task: add detect count for hung tasks
Date: Fri, 1 Nov 2024 19:48:33 +0800 [thread overview]
Message-ID: <20241101114833.8377-1-ioworker0@gmail.com> (raw)
In-Reply-To: <20241027120747.42833-2-ioworker0@gmail.com>
Hi Andrew,
Sorry, I made a stupid mistake :(
sysctl_hung_task_detect_count is defined as an unsigned long, so we need
to use proc_doulongvec_minmax instead of proc_dointvec to handle it
correctly. Could you please fold the following changes into this patch?
---
kernel/hung_task.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index 229ff3d4e501..c18717189f32 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -330,7 +330,7 @@ static struct ctl_table hung_task_sysctls[] = {
.data = &sysctl_hung_task_detect_count,
.maxlen = sizeof(unsigned long),
.mode = 0444,
- .proc_handler = proc_dointvec,
+ .proc_handler = proc_doulongvec_minmax,
},
};
--
Thanks,
Lance
next prev parent reply other threads:[~2024-11-01 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 12:07 [PATCH v2 0/2] " Lance Yang
2024-10-27 12:07 ` [PATCH v2 1/2] hung_task: " Lance Yang
2024-11-01 11:48 ` Lance Yang [this message]
2024-10-27 12:07 ` [PATCH v2 2/2] hung_task: add docs for hung_task_detect_count Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101114833.8377-1-ioworker0@gmail.com \
--to=ioworker0@gmail.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=cunhuang@tencent.com \
--cc=david@redhat.com \
--cc=dj456119@gmail.com \
--cc=j.granados@samsung.com \
--cc=joel.granados@kernel.org \
--cc=jsiddle@redhat.com \
--cc=kent.overstreet@linux.dev \
--cc=leonylgao@tencent.com \
--cc=libang.li@antgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@weissschuh.net \
--cc=mingzhe.yang@ly.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®