From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 956F916A959 for ; Fri, 1 Nov 2024 13:42:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730468526; cv=none; b=GMJyA7KlB1qUy10wxzBHR9B7S+AGBTdFjcWBXg35w+Os33Vq2bF3J/tgiG+lIulOF99lKNDHByFrvTEgDGtUvPCTlcSK6PBvVX/vFSQn0PNqKtg+gazv6cm7Bun1MIuIgfh9Q6GKvtpe1fIPUT3bq2bOftZ93J+ki48e82W/G/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730468526; c=relaxed/simple; bh=cJXYvW3abe/MNE3Xc2VsElqZLA7my5VNctTFJ04d030=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GS3pkNbcuIlqUsiPpuWqUnW4h0v36Fqlbdc490le9bBs9JkNJ+P0vhsS0CM8vixu97PLHmKLRtAJNj9E/XZIEZuP21+F3ML5cRjWss3F2W+gGgR7dDHrbZGzzJ8iSP+EuO7oBe2iTi2Yp9MuUthTTRSRVNwNrttywWp16e0+c2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=YRF1Vn6k; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="YRF1Vn6k" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7b161fa1c7bso131738985a.0 for ; Fri, 01 Nov 2024 06:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1730468523; x=1731073323; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cJXYvW3abe/MNE3Xc2VsElqZLA7my5VNctTFJ04d030=; b=YRF1Vn6kYj94b6Gof8NYIJIsnUMDd3N604tcBd46qC4CVySJK2JnSZSSPppzI6mYdL lCLSxpXkTldibD+PGragg18jFog1Gpd4AcxdZiAHdn+VmUbqQCJZ3x51tk4c5ksekelS NJkFHwLGD3E9B3KwqLl/q2TB7twPJ1NJoQu/I3QY/REPNoGWdeoIShPa3bU2f473geCo uRD6VIBUozP3rVEfxZIiBAuHygIFpSAMsPT3x8NlN38q/jxB5U0wi9VyEivBaHHiql8J tvbOhmF7rvfFaOxz816+sXq6TthHZ8aZV+HTUFjV99zsuhj35Wow637iJ16vpSVok7l1 JwVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730468523; x=1731073323; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cJXYvW3abe/MNE3Xc2VsElqZLA7my5VNctTFJ04d030=; b=mNSiyzVsiNXkx+Nb3ImJJ7ZlFgJVSbwWquNiASOwc5mCR0g9UgSSHq6gAPIMqUJk0t tbFmKXYTb9uMRHwHq43SfagM9DmoX52a2SWj9iYl89zUG/xHD+BQ6QeBc1BZNXW/dbhx FE6CmN8wnGvJ9qsMN71bnvwjW68BE0Fz8UibcwaQnVLFmWriQfFCfdka4334eD6S+bb4 U/GomPe/QPnM9JplExp50B+W4v0CpLWKjy3grrfgIpyE11UV/rPvDFjGV4NITKsLkBiS GnSUdmOibSI6wv5MEFnvcGv/pwEtbiRGCoCa45wPBCvuzLtXXeoGbGrs+lrLBdTuSeGK bxcg== X-Forwarded-Encrypted: i=1; AJvYcCWxfMxYLTGjLvsDOA5QvliwNe9n5UuZCsbzw40BctO/Fobwk+3rMbY3PDK09BC3xpwbYcXH6aDr6be1IR8=@vger.kernel.org X-Gm-Message-State: AOJu0YxCKhS1jQJZKMHnBqRm4RNhIgRkGK2rCGU7MRREEz5GV31SyZEy kWBD1qz1jDcpxfjeIBp7ovEm5bT6Zn+x45l2nUGnfAcKcsjw6J2h88ArhBR1PCc= X-Google-Smtp-Source: AGHT+IHKsnAIBL5bwiLhih6bmC6tVm4aSQJMldIeDtc2HksBE6g03HuX0ip2Xi6rBdXjkAjc21j7GA== X-Received: by 2002:a05:6214:4a81:b0:6cb:bfb5:6fc with SMTP id 6a1803df08f44-6d1856fb9dcmr414876706d6.25.1730468523486; Fri, 01 Nov 2024 06:42:03 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d354178d31sm19306126d6.118.2024.11.01.06.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2024 06:42:02 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1t6ruc-00000000SZq-12Ar; Fri, 01 Nov 2024 10:42:02 -0300 Date: Fri, 1 Nov 2024 10:42:02 -0300 From: Jason Gunthorpe To: "Gowans, James" Cc: "quic_eberman@quicinc.com" , "kvm@vger.kernel.org" , "rppt@kernel.org" , "brauner@kernel.org" , "anthony.yznaga@oracle.com" , "steven.sistare@oracle.com" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "seanjc@google.com" , "Durrant, Paul" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Woodhouse, David" , "Saenz Julienne, Nicolas" , "viro@zeniv.linux.org.uk" , "Graf (AWS), Alexander" , "jack@suse.cz" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH 05/10] guestmemfs: add file mmap callback Message-ID: <20241101134202.GB35848@ziepe.ca> References: <20240805093245.889357-1-jgowans@amazon.com> <20240805093245.889357-6-jgowans@amazon.com> <20241029120232032-0700.eberman@hu-eberman-lv.qualcomm.com> <33a2fd519edc917d933517842cc077a19e865e3f.camel@amazon.com> <20241031160635.GA35848@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Nov 01, 2024 at 01:01:00PM +0000, Gowans, James wrote: > Thanks Jason, that sounds perfect. I'll work on the next rev which will: > - expose a filesystem which owns reserved/persistent memory, just like > this patch. Is this step needed? If the guest memfd is already told to get 1G pages in some normal way, why do we need a dedicated pool just for the KHO filesystem? Back to my suggestion, can't KHO simply freeze the guest memfd and then extract the memory layout, and just use the normal allocator? Or do you have a hard requirement that only KHO allocated memory can be preserved across kexec? Jason