From: Dave Penkler <dpenkler@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: skhan@linuxfoundation.org, arnd@arndb.de,
dan.carpenter@linaro.org, Dave Penkler <dpenkler@gmail.com>
Subject: [PATCH 01/11] staging: gpib: Fix buffer overflow in ni_usb_init
Date: Sun, 3 Nov 2024 22:26:07 +0100 [thread overview]
Message-ID: <20241103212617.13076-2-dpenkler@gmail.com> (raw)
In-Reply-To: <20241103212617.13076-1-dpenkler@gmail.com>
The writes buffer size was not taking into account the number of
entries in the array which was causing random oopses.
Fixes: 4e127de14fa7 ("staging: gpib: Add National Instruments USB GPIB driver")
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
index 571f07800c9a..b7550a937f15 100644
--- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
+++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
@@ -1726,7 +1726,7 @@ static int ni_usb_init(gpib_board_t *board)
unsigned int ibsta;
int writes_len;
- writes = kmalloc(sizeof(*writes), GFP_KERNEL);
+ writes = kmalloc_array(NUM_INIT_WRITES, sizeof(*writes), GFP_KERNEL);
if (!writes)
return -ENOMEM;
--
2.46.2
next prev parent reply other threads:[~2024-11-03 21:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 21:26 [PATCH v2 00/11] staging: gpib: Patch set for gpib staging drivers Dave Penkler
2024-11-03 21:26 ` Dave Penkler [this message]
2024-11-03 21:26 ` [PATCH 02/11] staging: gpib: Replace custom debug with dev_dbg Dave Penkler
2024-11-03 21:26 ` [PATCH 03/11] staging: gpib: Update messaging and usb_device refs in ni_usb Dave Penkler
2024-11-03 21:26 ` [PATCH 04/11] staging: gpib: Update messaging and usb_device refs in agilent_usb Dave Penkler
2024-11-04 8:42 ` Dan Carpenter
2024-11-03 21:26 ` [PATCH 05/11] staging: gpib: Remove GPIB_DEBUG reference and update messaging Dave Penkler
2024-11-04 8:43 ` Dan Carpenter
2024-11-03 21:26 ` [PATCH 06/11] staging: gpib: Use dev_xxx for messaging Dave Penkler
2024-11-03 21:26 ` [PATCH 07/11] staging: gpib: Fix Kconfig Dave Penkler
2024-11-03 21:26 ` [PATCH 08/11] staging: gpib: Remove unneeded lookup table Dave Penkler
2024-11-03 21:26 ` [PATCH 09/11] staging: gpib: Remove GPIO14 and GPIO15 lines in lookup tables Dave Penkler
2024-11-03 21:26 ` [PATCH 10/11] staging: gpib: Re-order the " Dave Penkler
2024-11-04 8:36 ` Dan Carpenter
2024-11-03 21:26 ` [PATCH 11/11] staging: gpib: Correct check for max secondary address Dave Penkler
2024-11-04 8:09 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241103212617.13076-2-dpenkler@gmail.com \
--to=dpenkler@gmail.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome