From: 이진수 <jinsu1.lee@samsung.com>
To: "linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>
Cc: "chao@kernel.org" <chao@kernel.org>,
"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
이진수 <jinsu1.lee@samsung.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to avoid forcing direct write to use buffered IO on inline_data inode
Date: Mon, 04 Nov 2024 18:44:12 +0900 [thread overview]
Message-ID: <20241104094412epcms2p13f82502b0ff6167ff30eb76c6dda41de@epcms2p1> (raw)
In-Reply-To: <CGME20241104094412epcms2p13f82502b0ff6167ff30eb76c6dda41de@epcms2p1>
>>> Jinsu Lee reported a performance regression issue, after commit
>>
>>> 5c8764f8679e ("f2fs: fix to force buffered IO on inline_data
>>
>>> inode"), we forced direct write to use buffered IO on inline_data
>>
>>> inode, it will cause performace regression due to memory copy
>>
>>> and data flush.
>>
>>
>>> It's fine to not force direct write to use buffered IO, as it
>>
>>> can convert inline inode before committing direct write IO.
>>
>>
>>>> Fixes: 5c8764f8679e ("f2fs: fix to force buffered IO on inline_data inode")
>>
>>> Reported-by: Jinsu Lee <jinsu1.lee@samsung.com>
>>
>>> Closes: https://lore.kernel.org/linux-f2fs-devel/af03dd2c-e361-4f80-b2fd-39440766cf6e@kernel.org
>>
>>> Signed-off-by: Chao Yu <chao@kernel.org>
>>
>>> ---
>>
>>> fs/f2fs/file.c | 6 +++++-
>>
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>>
>>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>>
>>> index 0e7a0195eca8..377a10b81bf3 100644
>>
>>> --- a/fs/f2fs/file.c
>>
>>> +++ b/fs/f2fs/file.c
>>
>>> @@ -883,7 +883,11 @@ static bool f2fs_force_buffered_io(struct inode *inode, int rw)
>>
>>> return true;
>>
>>> if (f2fs_compressed_file(inode))
>>
>>> return true;
>>
>>> - if (f2fs_has_inline_data(inode))
>>
>>> + /*
>>
>>> + * only force direct read to use buffered IO, for direct write,
>>
>>> + * it expects inline data conversion before committing IO.
>>
>>> + */
>>
>>> + if (f2fs_has_inline_data(inode) && rw == READ)
>>
>>
>> Chao Yu,
>>
>> The fio direct performance problem I reported did not improve when reflecting this commit.
>>
>> Rather, it has been improved when reflecting your commit below.
>>
>>
>> The previous commit seems to be mistitled as read and the following commit appears to be the final version.
>>
>> The reason for the improvement with the commit below is that there is no "m_may_create" condition
>>
>> when performing "io_submit" directly, so performance regression issue may occur.
>>
>>
>> I wonder if "rw == READ" should be additionally reflected.
>
> Alright, thanks for your feedback.
>
> I thought you have bisected this performance issue to commit
> 5c8764f8679e ("f2fs: fix to force buffered IO on inline_data inode"),
> so I sent this patch for comments.
>
> Can you please apply both below dio fixes, and help to check final
> performance?
>
> https://lore.kernel.org/linux-f2fs-devel/20241104015016.228963-1-chao@kernel.org
> https://lore.kernel.org/linux-f2fs-devel/20241104013551.218037-1-chao@kernel.org
>
> Thanks,
Chao Yu,
After reflecting the following two commits, the fio DIO seq write operates with normal performance.
https://lore.kernel.org/linux-f2fs-devel/20241104015016.228963-1-chao@kernel.org
https://lore.kernel.org/linux-f2fs-devel/20241104013551.218037-1-chao@kernel.org
However, Antutu Apk's "AI READ" performance has more than tripled compared to before patch reflection, so it seems necessary to check if there is any problem with DIO performance.
next parent reply other threads:[~2024-11-04 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241104094412epcms2p13f82502b0ff6167ff30eb76c6dda41de@epcms2p1>
2024-11-04 9:44 ` 이진수 [this message]
[not found] <CGME20241104022816epcms2p2213e9a1b0003cfeb30521927252b6bbe@epcms2p2>
[not found] ` <20241104022816epcms2p2213e9a1b0003cfeb30521927252b6bbe@epcms2p2>
2024-11-04 3:40 ` Chao Yu
2024-11-04 1:50 Chao Yu
2024-11-18 17:00 ` [f2fs-dev] " patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104094412epcms2p13f82502b0ff6167ff30eb76c6dda41de@epcms2p1 \
--to=jinsu1.lee@samsung.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®