mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bitao Hu <yaoma@linux.alibaba.com>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org
Cc: linux-kernel@vger.kernel.org, yaoma@linux.alibaba.com
Subject: [PATCH] sched: Remove unnecessary initialization in init_cfs_bandwidth() function
Date: Mon,  4 Nov 2024 20:14:43 +0800	[thread overview]
Message-ID: <20241104121443.86468-1-yaoma@linux.alibaba.com> (raw)

The root task group is statically defined, and non-root task groups
are allocated memory using kmem_cache_alloc() with the __GFP_ZERO
flag. In both cases, the corresponding 'struct cfs_bandwidth' is a
block of all-zero memory. Therefore, it is unnecessary to explicitly
set zeros in the init_cfs_bandwidth() function.

Signed-off-by: Bitao Hu <yaoma@linux.alibaba.com>
---
 kernel/sched/fair.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 2d16c8545c71..2fd96641164f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6573,10 +6573,8 @@ static enum hrtimer_restart sched_cfs_period_timer(struct hrtimer *timer)
 void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b, struct cfs_bandwidth *parent)
 {
 	raw_spin_lock_init(&cfs_b->lock);
-	cfs_b->runtime = 0;
 	cfs_b->quota = RUNTIME_INF;
 	cfs_b->period = ns_to_ktime(default_cfs_period());
-	cfs_b->burst = 0;
 	cfs_b->hierarchical_quota = parent ? parent->hierarchical_quota : RUNTIME_INF;
 
 	INIT_LIST_HEAD(&cfs_b->throttled_cfs_rq);
-- 
2.46.0


             reply	other threads:[~2024-11-04 12:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 12:14 Bitao Hu [this message]
2024-11-04 12:18 ` Peter Zijlstra
2024-11-05  1:21   ` yaoma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241104121443.86468-1-yaoma@linux.alibaba.com \
    --to=yaoma@linux.alibaba.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®