From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2245F1C302B; Mon, 4 Nov 2024 16:17:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730737074; cv=none; b=R/hPJ/Vcc1lZb1VpOIsWNaTnTXUB6uawf09w3z9t18MktotYa6Cnq01fP2FkQJN6/bBa505rnKpg6B6zIQ9/zhxiWqvDLCwEhl8Hcx7XuOCZ8bJO803NZpnfy66vHAW1tyUiYDk9jQYkSCFbpAHwMJlVFXSN7MvToNlT8oWVjMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730737074; c=relaxed/simple; bh=bfAsiSNijIbn9dA6dCEoAJCNnIpUVnYgwURSK8OS4ug=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IQobsu5VIIO0CwXbww039kEDHa0/CXJdYHHK64Cdfdwlp+dlQuyk9aHYM5wgHRstQ5aj4N5sROgIm+YRmg5eW+oDsYexrLYOGK3RiNyX1esar8OlBdstoNlH3TaaI4uI2RaskbtNzdVYc2xssA3PRlYSObUAbcpPpDZt2M5bX+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ELeHiV4v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ELeHiV4v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E502C4CECE; Mon, 4 Nov 2024 16:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730737073; bh=bfAsiSNijIbn9dA6dCEoAJCNnIpUVnYgwURSK8OS4ug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ELeHiV4vJKBVJKglPnNwM4FU9h4OgvTXusWR8lAPnMYQkdfviOs8EYxwcL7BFbdiL 2RVJSf42kx/VHzzyjb4XTns0+4vRba32OT2rKvpm8SOwYAx5UdrChcvvsSZ2CEFndf daO4CLeyWE5Lbh8G7KVLF5o9n7K3VsPFRKrVV44BpsC97egsW8iREvcfqojKpnzwj1 03GkPzA0xMlNzY9F/Q3KiNX+Iqyda+V0dAPhUZYMyiihT49jsH9JICKfJKpendetVR cx3TENatm5/RUWWRx9XlsjY818EJGeRDOmYYG69p1JW1AKCDsHHhDGMSFgkG2nm4P1 lv2vYvcLarrcw== Date: Mon, 4 Nov 2024 10:17:51 -0600 From: Rob Herring To: Ki-Seok Jo Cc: Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linux-sound@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 1/2] ASoC: dt-bindings: irondevice,sma1307: Add initial DT binding Message-ID: <20241104161751.GA320514-robh@kernel.org> References: <20241104-irondevice-sma1307-v3-0-4bbe79895f54@irondevice.com> <20241104-irondevice-sma1307-v3-1-4bbe79895f54@irondevice.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 04, 2024 at 07:33:47AM +0000, Ki-Seok Jo wrote: > I don't see the rest of the series (I fetch from lore). That means your threading is broken. > This adds the schema binding for the Iron Device SMA1307 Amp > > Signed-off-by: Kiseok Jo > --- v3, but where is the revision history? > .../bindings/sound/irondevice,sma1307.yaml | 54 ++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml > new file mode 100644 > index 000000000..0bb4ee664 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 "%YAML 1.2" goes on the 2nd line. > +--- > +$id: http://devicetree.org/schemas/sound/irondevice,sma1307.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Iron Device SMA1307 Audio Amplifier > + > +maintainers: > + - Kiseok Jo > + > +description: > + SMA1307 boosted digital speaker amplifier > + with feedback-loop. Wrap lines at 80 char. > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + enum: > + - irondevice,sma1307a > + - irondevice,sma1307aq > + description: > + If a 'q' is added, it indicated the product is AEC-Q100 > + qualified for automotive applications. SMA1307A supports > + both WLCSP and QFN packages. However, SMA1307AQ only > + supports the QFN package. Is this difference visible to software? The package is not, so that part is irrelevant. > + > + reg: > + maxItems: 1 > + > + '#sound-dai-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - '#sound-dai-cells' > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + amplifier@1e { > + compatible = "irondevice,sma1307a"; > + reg = <0x1e>; > + #sound-dai-cells = <1>; > + }; > + }; > > -- > 2.39.2 >