From: Nir Lichtman <nir@lichtman.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: Fix incorrect paths/magic in magic numbers rst
Date: Mon, 4 Nov 2024 20:03:28 +0000 [thread overview]
Message-ID: <20241104200328.GA73996@lichtman.org> (raw)
In-Reply-To: <871pzq94hp.fsf@trenco.lwn.net>
On Mon, Nov 04, 2024 at 12:35:30PM -0700, Jonathan Corbet wrote:
> Nir Lichtman <nir@lichtman.org> writes:
>
> > Fix some no longer true header/c file paths and correct the BAYCOM_MAGIC
> > value to be decimal as in the source instead of incorrectly hexadecimal
> >
> > Signed-off-by: Nir Lichtman <nir@lichtman.org>
> > ---
> > Documentation/staging/magic-number.rst | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
>
> I've applied this, thanks. I do continue to wonder about the value of
> this file in general, though...
Agreed, it feels pretty much like abandoned book keeping that gives minimal
value since the chance of magics colliding is slim, but I think the general tip
before the table of magics is pretty good.
What is your opinion about integrating the tip in a different page and deleting
this page entirely?
Thanks,
Nir
>
> jon
next prev parent reply other threads:[~2024-11-04 20:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 13:51 Nir Lichtman
2024-11-04 19:35 ` Jonathan Corbet
2024-11-04 20:03 ` Nir Lichtman [this message]
2024-11-04 20:10 ` Jonathan Corbet
2024-11-07 21:01 ` Nir Lichtman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104200328.GA73996@lichtman.org \
--to=nir@lichtman.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®