From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Lucas Stach <l.stach@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Sui Jingfeng <sui.jingfeng@linux.dev>
Subject: [etnaviv-next v2 2/3] drm/etnaviv: Fix the debug log of the etnaviv_iommu_map()
Date: Tue, 5 Nov 2024 04:03:53 +0800 [thread overview]
Message-ID: <20241104200354.656525-3-sui.jingfeng@linux.dev> (raw)
In-Reply-To: <20241104200354.656525-1-sui.jingfeng@linux.dev>
The value of the 'iova' variable is the base GPU virtual address that is
going to be mapped, its value won't get updated when etnaviv_context_map()
is running under the "for_each_sgtable_dma_sg(sgt, sg, i) {}" loop.
Replace it with the 'da' variable, reflect the actual status that GPUVA
is being mapped.
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
---
drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
index ddb536d84c58..05021848126e 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
@@ -86,7 +86,7 @@ static int etnaviv_iommu_map(struct etnaviv_iommu_context *context,
unsigned int da_len = sg_dma_len(sg);
unsigned int bytes = min_t(unsigned int, da_len, va_len);
- VERB("map[%d]: %08x %pap(%x)", i, iova, &pa, bytes);
+ VERB("map[%d]: %08x %pap(%x)", i, da, &pa, bytes);
ret = etnaviv_context_map(context, da, pa, bytes, prot);
if (ret)
--
2.34.1
next prev parent reply other threads:[~2024-11-04 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 20:03 [etnaviv-next v2 0/3] drm/etnaviv: Trivial mmu map and ummap cleanups Sui Jingfeng
2024-11-04 20:03 ` [etnaviv-next v2 1/3] drm/etnaviv: Drop offset in page manipulation Sui Jingfeng
2024-11-04 20:03 ` Sui Jingfeng [this message]
2024-11-04 20:03 ` [etnaviv-next v2 3/3] drm/etnaviv: Improve VA, PA, SIZE alignment checking Sui Jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104200354.656525-3-sui.jingfeng@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=airlied@gmail.com \
--cc=christian.gmeiner@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®