mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
	michael.christie@oracle.com, sgarzare@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: [PATCH v3 2/9] vhost: Add the vhost_worker to support kthread
Date: Tue,  5 Nov 2024 15:25:21 +0800	[thread overview]
Message-ID: <20241105072642.898710-3-lulu@redhat.com> (raw)
In-Reply-To: <20241105072642.898710-1-lulu@redhat.com>

Add the previously removed function vhost_worker() back
to support the kthread and rename it to vhost_run_work_kthread_list.

The old function vhost_worker was change to support task in
commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads")
change to xarray in
commit 1cdaafa1b8b4 ("vhost: replace single worker pointer with xarray")

Signed-off-by: Cindy Lu <lulu@redhat.com>
---
 drivers/vhost/vhost.c | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index eff6acbbb63b..65fda810b96e 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -389,6 +389,44 @@ static void vhost_vq_reset(struct vhost_dev *dev,
 	__vhost_vq_meta_reset(vq);
 }
 
+static int vhost_run_work_kthread_list(void *data)
+{
+	struct vhost_worker *worker = data;
+	struct vhost_work *work, *work_next;
+	struct vhost_dev *dev = worker->dev;
+	struct llist_node *node;
+
+	kthread_use_mm(dev->mm);
+
+	for (;;) {
+		/* mb paired w/ kthread_stop */
+		set_current_state(TASK_INTERRUPTIBLE);
+
+		if (kthread_should_stop()) {
+			__set_current_state(TASK_RUNNING);
+			break;
+		}
+		node = llist_del_all(&worker->work_list);
+		if (!node)
+			schedule();
+
+		node = llist_reverse_order(node);
+		/* make sure flag is seen after deletion */
+		smp_wmb();
+		llist_for_each_entry_safe(work, work_next, node, node) {
+			clear_bit(VHOST_WORK_QUEUED, &work->flags);
+			__set_current_state(TASK_RUNNING);
+			kcov_remote_start_common(worker->kcov_handle);
+			work->fn(work);
+			kcov_remote_stop();
+			cond_resched();
+		}
+	}
+	kthread_unuse_mm(dev->mm);
+
+	return 0;
+}
+
 static bool vhost_run_work_list(void *data)
 {
 	struct vhost_worker *worker = data;
-- 
2.45.0


  parent reply	other threads:[~2024-11-05  7:27 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05  7:25 [PATCH v3 0/9] vhost: Add support of kthread API Cindy Lu
2024-11-05  7:25 ` [PATCH v3 1/9] vhost: Add a new parameter to allow user select kthread Cindy Lu
2024-11-05  9:32   ` Jason Wang
2024-11-05  7:25 ` Cindy Lu [this message]
2024-11-05  7:25 ` [PATCH v3 3/9] vhost: Add the cgroup related function Cindy Lu
2024-11-25 15:22   ` Mike Christie
2024-11-27  6:44     ` Cindy Lu
2024-11-05  7:25 ` [PATCH v3 4/9] vhost: Add kthread support in function vhost_worker_create Cindy Lu
2024-11-05  9:36   ` Jason Wang
2024-11-06  9:21     ` Cindy Lu
2024-11-26 21:19   ` michael.christie
2024-11-27  6:43     ` Cindy Lu
2024-11-05  7:25 ` [PATCH v3 5/9] vhost: Add kthread support in function vhost_worker_queue() Cindy Lu
2024-11-05  9:37   ` Jason Wang
2024-11-07 10:38   ` Dan Carpenter
2024-11-07 11:12     ` Dan Carpenter
2024-11-05  7:25 ` [PATCH v3 6/9] vhost: Add kthread support in function vhost_worker_destroy() Cindy Lu
2024-11-07 11:24   ` Dan Carpenter
2024-11-05  7:25 ` [PATCH v3 7/9] vhost: Add new UAPI to support change to task mode Cindy Lu
2024-11-05  9:39   ` Jason Wang
2024-11-25 15:19     ` Mike Christie
2024-11-05 10:31   ` Stefano Garzarella
2024-11-07  7:12     ` Cindy Lu
2024-11-07 10:03       ` Stefano Garzarella
2024-11-07 11:50         ` Cindy Lu
2024-11-06  7:31   ` Michael S. Tsirkin
2024-11-06  7:33   ` Michael S. Tsirkin
2024-11-05  7:25 ` [PATCH v3 8/9] vhost_scsi: Add check for inherit_owner status Cindy Lu
2024-11-25 15:00   ` Mike Christie
2024-11-05  7:25 ` [PATCH v3 9/9] vhost: Expose the modparam inherit_owner_default Cindy Lu
2024-12-10 11:09 ` [PATCH v3 0/9] vhost: Add support of kthread API Lei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241105072642.898710-3-lulu@redhat.com \
    --to=lulu@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®