From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 944681FEFCE; Tue, 5 Nov 2024 07:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730792707; cv=none; b=V/pc5xbbCjQBipL+PCNXnkwvW8uXyAlXaxomXRReAHYs05/fzFGA6OluO+XmTtUTJ6ZlqqaNlDx4tV3iGsLpdcwx0+7TfpT3z8NS/+VAQJhimzuE2HQGJuyYGkp3eHOdJnp+5xdXwra0S/C1j9v5cfOha4b/KC5jP0k/rZiGfTk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730792707; c=relaxed/simple; bh=vczv3umx0JydadJ/rhiMMN1HnxrR6WMwbmLBCUWYarE=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wp8qSJ5sqNuWMXpIzUuBweP+h21dgUZjkl6omt9yHdVtD0LT+GqVqN1f9FCxaRlp5EFAiG0Z+NjkOFWi8E66RuGQMeEpQX5smmb0Ota5D+9N5oDSAk7CyyGwau8rUQT8gS/HL6WZPjw7+oL3SNw2i8bsN1ZWFC7g4Iz7HQG9P5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=TYud5OSX; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="TYud5OSX" Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A51Uir2031627; Tue, 5 Nov 2024 08:44:39 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=selector1; bh=fMy/3ePTYEdmuHR3oKMj/7pQ zddxJhXpPNgNE56LFM8=; b=TYud5OSXJDURjb9WH8OmxgZpzywYjos0gnr1wt5Z FNeMncJw+I5gU7N0V0M9fU6GzkpIGQY+XumBwW5/V5u6BTXviHXL1CcptzIJ6aQa 5Ve/UCUI9t61hDreoemI9COiPDCOnV8rC4FIzc77pEi1lecCePpvBtodQfVWdrPK 1p4Y+8SA/PArMWPIqvcbF4o8XuyWNan7fez+86HUEMfTvpWNHGge4emn7Nr4FhfZ 31jTNznH5v7uht3DXTSya1cOkJLtWcpiGX8sf5+6g3NiUtc2eGgedYiZy9Pj+Eo1 YMexn77m9RFBtlhCmEnJITW+PmP3dHO98l8rAnqX80YMSw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 42nd05aruy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Nov 2024 08:44:38 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id E502340046; Tue, 5 Nov 2024 08:43:21 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 0658024C45D; Tue, 5 Nov 2024 08:42:25 +0100 (CET) Received: from gnbcxd0016.gnb.st.com (10.129.178.213) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 5 Nov 2024 08:42:24 +0100 Date: Tue, 5 Nov 2024 08:42:17 +0100 From: Alain Volmat To: Krzysztof Kozlowski CC: Hugues Fruchet , Mauro Carvalho Chehab , Maxime Coquelin , Alexandre Torgue , Hans Verkuil , Sakari Ailus , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , , , , , Subject: Re: [PATCH 02/15] dt-bindings: media: addition of stm32 csi driver description Message-ID: <20241105074115.GA1413559@gnbcxd0016.gnb.st.com> References: <20241008-csi_dcmipp_mp25-v1-0-e3fd0ed54b31@foss.st.com> <20241008-csi_dcmipp_mp25-v1-2-e3fd0ed54b31@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Disclaimer: ce message est personnel / this message is private X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 Hi Krzysztof, On Tue, Oct 08, 2024 at 03:23:10PM +0200, Krzysztof Kozlowski wrote: > On Tue, Oct 08, 2024 at 01:18:04PM +0200, Alain Volmat wrote: > > Addition of the stm32 csi controller driver > > This is supposed to be about hardware, not driver. Missing full stop. Ok, commit message corrected in the upcoming v2. > > > > > Signed-off-by: Alain Volmat > > --- > > .../devicetree/bindings/media/st,stm32-csi.yaml | 129 +++++++++++++++++++++ > > Use compatible as filename. Fixed > > > 1 file changed, 129 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/st,stm32-csi.yaml b/Documentation/devicetree/bindings/media/st,stm32-csi.yaml > > new file mode 100644 > > index 000000000000..71e7c51be58c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/st,stm32-csi.yaml > > @@ -0,0 +1,129 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/st,stm32-csi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: STMicroelectronics STM32 CSI controller > > + > > +description: > > + The STM32 CSI controller allows connecting a CSI based > > + camera to the DCMIPP camera pipeline. > > + > > +maintainers: > > + - Alain Volmat > > + > > +properties: > > + compatible: > > + enum: > > + - st,stm32mp25-csi > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 3 > > + > > + clock-names: > > + items: > > + - const: pclk > > + - const: txesc > > + - const: csi2phy > > + > > + resets: > > + maxItems: 1 > > + > > + vdd-supply: > > + description: Digital core power supply (0.91V) > > + > > + vdda18-supply: > > + description: System analog power supply (1.8V) > > + > > + access-controllers: > > + minItems: 1 > > + maxItems: 2 > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: > > + Input port node > > + > > + properties: > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + description: > > + Indicate the number of data-lanes and their mapping. > > + > > + items: > > Drop Done > > ... and test your patches. Mailing list is not the place to test them. > Your machine is. I did, however my dtschema was too old hence not reporting the issue. Once updated I now got the error reported and fixed that. > > > + minItems: 1 > > + items: > > + - const: 1 > > + - const: 2 > > + > > + required: > > + - data-lanes > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Output port node > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - resets > > + - ports > > Best regards, > Krzysztof > Regards, Alain