From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D02DE1D0E23 for ; Wed, 6 Nov 2024 22:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730930532; cv=none; b=oKIqlH7vHTiJ7Qyt0qBmEgWcDAuRu7KXg1ImPXA11k7oeSd+t//SJYnNmT3+glaoYKfi3nEdv+bhPABCy1cITjCd1dGDpYztVRFJgriZh2nx1yRQk7dZA14n+toDNrd0+y+Jg6QVH0PxuqZJy8DLwjJ5nxzImgVAEGx4vdvGmpo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730930532; c=relaxed/simple; bh=qQomBuQN4Q81ObHmsV989becOTbHMcs1fG5+uVha8/s=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=EmUeEaxZUXuoDeq1ExoedCn17oS+oEWI/fq2j7kW+xwekC4fmJVYqPPlA8X0+6hI+vgOWLXjiKgHgAGi/yjQOUzTknW5L3buL+nkid//SgiH7XGOgikvRcnJ6aWAcszLMydyT/NsvKDhPxWGn9POHnPSN6r+GL1MmAGpKQyNmuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=kHW6ciBR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="kHW6ciBR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9456AC4CEC6; Wed, 6 Nov 2024 22:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1730930532; bh=qQomBuQN4Q81ObHmsV989becOTbHMcs1fG5+uVha8/s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kHW6ciBRy1vtLDHEZh8B8siDDtOV9Uwhq6QqqFCpUDHK1lO2G2L0MDuje4PXoU1rE xy9DUV5UvujjGYKBvNgc7ghd7OE4yL/JrIhquwsg7IjRMg22vXxlJ4wUIacpeoWbJu lPrJ4Rl5+p2ftgh8ljEIEoI51eRIesaepqkVmbkc= Date: Wed, 6 Nov 2024 14:02:11 -0800 From: Andrew Morton To: Barry Song <21cnbao@gmail.com> Cc: Kanchana P Sridhar , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Nhat Pham , Usama Arif , Chengming Zhou , Yosry Ahmed , Hailong Liu , David Hildenbrand , Hugh Dickins , Matthew Wilcox , Shakeel Butt , Andi Kleen , Baolin Wang , Chris Li , "Huang, Ying" , Kairui Song , Ryan Roberts Subject: Re: [PATCH v3] mm: count zeromap read and set for swapout and swapin Message-Id: <20241106140211.a1272fe0e23d99d7c37b7751@linux-foundation.org> In-Reply-To: References: <20241105211934.5083-1-21cnbao@gmail.com> <20241106150631.GA1172372@cmpxchg.org> <20241106124225.632b42c3680cae0b940d2871@linux-foundation.org> <20241106134446.aaadc57a2a88c9efe899c838@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Thu, 7 Nov 2024 10:53:11 +1300 Barry Song <21cnbao@gmail.com> wrote: > > Kanchana's commit 'mm: change count_objcg_event() to count_objcg_events()' > changes count_objcg_event() to count_objcg_events() and supports > nr_pages more than 1. This is what we need for the minimal patch of > fixing zeromap > as zeromap could be nr_pages > 1 for large folios. > > So my question is that, do I combine Kanchana's change into my patch > and send a single patch, or do I send a patch series with 2 patches: > > 1: Kanchana's mm: change count_objcg_event() to count_objcg_events() > 2: mm: count zeromap read and set for swapout and swapin A single self-contained backportable patch is preferable, please. > If we combine them into a single patch, I'll need to incorporate the changes > from 1 into 2. I'm also unsure how to acknowledge Kanchana's contribution > —perhaps mark it as co-developed? Sure.