From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Matthew Brost <matthew.brost@intel.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH 1/4] iov_iter: Provide copy_iomem_to|from_iter()
Date: Thu, 7 Nov 2024 17:34:45 +0100 [thread overview]
Message-ID: <20241107163448.2123-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20241107163448.2123-1-michal.wajdeczko@intel.com>
Define simple copy helpers that work on I/O memory. This will
allow reuse of existing framework functions in new use cases.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
---
include/linux/uio.h | 4 ++++
lib/iov_iter.c | 42 ++++++++++++++++++++++++++++++++++++++++++
2 files changed, 46 insertions(+)
diff --git a/include/linux/uio.h b/include/linux/uio.h
index 853f9de5aa05..6d2a24293bd1 100644
--- a/include/linux/uio.h
+++ b/include/linux/uio.h
@@ -178,6 +178,10 @@ size_t copy_page_to_iter(struct page *page, size_t offset, size_t bytes,
struct iov_iter *i);
size_t copy_page_from_iter(struct page *page, size_t offset, size_t bytes,
struct iov_iter *i);
+size_t copy_iomem_to_iter(const void __iomem *from, size_t offset,
+ size_t bytes, struct iov_iter *i);
+size_t copy_iomem_from_iter(void __iomem *to, size_t offset,
+ size_t bytes, struct iov_iter *i);
size_t _copy_to_iter(const void *addr, size_t bytes, struct iov_iter *i);
size_t _copy_from_iter(void *addr, size_t bytes, struct iov_iter *i);
diff --git a/lib/iov_iter.c b/lib/iov_iter.c
index 908e75a28d90..e8c1f1c68716 100644
--- a/lib/iov_iter.c
+++ b/lib/iov_iter.c
@@ -435,6 +435,48 @@ size_t copy_page_from_iter(struct page *page, size_t offset, size_t bytes,
}
EXPORT_SYMBOL(copy_page_from_iter);
+size_t copy_iomem_to_iter(const void __iomem *from, size_t offset,
+ size_t bytes, struct iov_iter *i)
+{
+ unsigned char buf[SMP_CACHE_BYTES];
+ size_t progress = 0, copied, len;
+
+ from += offset;
+ while (bytes) {
+ len = min(bytes, sizeof(buf));
+ memcpy_fromio(buf, from + progress, len);
+ copied = _copy_to_iter(buf, len, i);
+ if (!copied)
+ break;
+ bytes -= copied;
+ progress += copied;
+ }
+
+ return progress;
+}
+EXPORT_SYMBOL(copy_iomem_to_iter);
+
+size_t copy_iomem_from_iter(void __iomem *to, size_t offset,
+ size_t bytes, struct iov_iter *i)
+{
+ unsigned char buf[SMP_CACHE_BYTES];
+ size_t progress = 0, copied, len;
+
+ to += offset;
+ while (bytes) {
+ len = min(bytes, sizeof(buf));
+ copied = _copy_from_iter(buf, len, i);
+ if (!copied)
+ break;
+ memcpy_toio(to + progress, buf, copied);
+ bytes -= copied;
+ progress += copied;
+ }
+
+ return progress;
+}
+EXPORT_SYMBOL(copy_iomem_from_iter);
+
static __always_inline
size_t zero_to_user_iter(void __user *iter_to, size_t progress,
size_t len, void *priv, void *priv2)
--
2.43.0
next prev parent reply other threads:[~2024-11-07 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 16:34 [PATCH 0/4] Add iomem helpers for use from debugfs Michal Wajdeczko
2024-11-07 16:34 ` Michal Wajdeczko [this message]
2024-11-07 20:13 ` [PATCH 1/4] iov_iter: Provide copy_iomem_to|from_iter() Matthew Wilcox
2024-11-07 16:34 ` [PATCH 2/4] libfs: Provide simple_read_from|write_to_iomem() Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107163448.2123-2-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®