From: Mina Almasry <almasrymina@google.com>
To: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Mina Almasry <almasrymina@google.com>,
Pavel Begunkov <asml.silence@gmail.com>,
Willem de Bruijn <willemb@google.com>,
Kaiyuan Zhang <kaiyuanz@google.com>,
Samiullah Khawaja <skhawaja@google.com>,
linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: [PATCH net-next v2 4/5] page_pool: disable sync for cpu for dmabuf memory provider
Date: Thu, 7 Nov 2024 21:23:08 +0000 [thread overview]
Message-ID: <20241107212309.3097362-5-almasrymina@google.com> (raw)
In-Reply-To: <20241107212309.3097362-1-almasrymina@google.com>
dmabuf dma-addresses should not be dma_sync'd for CPU/device. Typically
its the driver responsibility to dma_sync for CPU, but the driver should
not dma_sync for CPU if the netmem is actually coming from a dmabuf
memory provider.
The page_pool already exposes a helper for dma_sync_for_cpu:
page_pool_dma_sync_for_cpu. Upgrade this existing helper to handle
netmem, and have it skip dma_sync if the memory is from a dmabuf memory
provider. Drivers should migrate to using this helper when adding
support for netmem.
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Signed-off-by: Mina Almasry <almasrymina@google.com>
---
include/net/page_pool/helpers.h | 25 +++++++++++++++++++------
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h
index 8e548ff3044c..ad4fed4a791c 100644
--- a/include/net/page_pool/helpers.h
+++ b/include/net/page_pool/helpers.h
@@ -429,9 +429,10 @@ static inline dma_addr_t page_pool_get_dma_addr(const struct page *page)
}
/**
- * page_pool_dma_sync_for_cpu - sync Rx page for CPU after it's written by HW
+ * page_pool_dma_sync_netmem_for_cpu - sync Rx page for CPU after it's written
+ * by HW
* @pool: &page_pool the @page belongs to
- * @page: page to sync
+ * @netmem: netmem to sync
* @offset: offset from page start to "hard" start if using PP frags
* @dma_sync_size: size of the data written to the page
*
@@ -440,16 +441,28 @@ static inline dma_addr_t page_pool_get_dma_addr(const struct page *page)
* Note that this version performs DMA sync unconditionally, even if the
* associated PP doesn't perform sync-for-device.
*/
-static inline void page_pool_dma_sync_for_cpu(const struct page_pool *pool,
- const struct page *page,
- u32 offset, u32 dma_sync_size)
+static inline void
+page_pool_dma_sync_netmem_for_cpu(const struct page_pool *pool,
+ const netmem_ref netmem, u32 offset,
+ u32 dma_sync_size)
{
+ if (pool->mp_priv)
+ return;
+
dma_sync_single_range_for_cpu(pool->p.dev,
- page_pool_get_dma_addr(page),
+ page_pool_get_dma_addr_netmem(netmem),
offset + pool->p.offset, dma_sync_size,
page_pool_get_dma_dir(pool));
}
+static inline void page_pool_dma_sync_for_cpu(const struct page_pool *pool,
+ struct page *page, u32 offset,
+ u32 dma_sync_size)
+{
+ page_pool_dma_sync_netmem_for_cpu(pool, page_to_netmem(page), offset,
+ dma_sync_size);
+}
+
static inline bool page_pool_put(struct page_pool *pool)
{
return refcount_dec_and_test(&pool->user_cnt);
--
2.47.0.277.g8800431eea-goog
next prev parent reply other threads:[~2024-11-07 21:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 21:23 [PATCH net-next v2 0/5] devmem TCP fixes Mina Almasry
2024-11-07 21:23 ` [PATCH net-next v2 1/5] net: page_pool: rename page_pool_alloc_netmem to *_netmems Mina Almasry
2024-11-08 15:53 ` Stanislav Fomichev
2024-11-07 21:23 ` [PATCH net-next v2 2/5] net: page_pool: create page_pool_alloc_netmem Mina Almasry
2024-11-08 15:53 ` Stanislav Fomichev
2024-11-07 21:23 ` [PATCH net-next v2 3/5] page_pool: Set `dma_sync` to false for devmem memory provider Mina Almasry
2024-11-08 15:53 ` Stanislav Fomichev
2024-11-08 16:34 ` Pavel Begunkov
2024-11-12 2:34 ` Jakub Kicinski
2024-11-07 21:23 ` Mina Almasry [this message]
2024-11-08 14:18 ` [PATCH net-next v2 4/5] page_pool: disable sync for cpu for dmabuf " Jason Gunthorpe
2024-11-08 15:58 ` Stanislav Fomichev
2024-11-08 16:39 ` Pavel Begunkov
2024-11-08 19:01 ` Mina Almasry
2024-11-15 1:59 ` Jason Gunthorpe
2024-11-22 22:10 ` Samiullah Khawaja
2024-11-24 2:33 ` Jakub Kicinski
2024-11-07 21:23 ` [PATCH net-next v2 5/5] netmem: add netmem_prefetch Mina Almasry
2024-11-08 2:56 ` kernel test robot
2024-11-08 3:29 ` kernel test robot
2024-11-08 4:21 ` kernel test robot
2024-11-08 15:55 ` Stanislav Fomichev
2024-11-12 2:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107212309.3097362-5-almasrymina@google.com \
--to=almasrymina@google.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jgg@ziepe.ca \
--cc=kaiyuanz@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhawaja@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®