From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFDBF233D92 for ; Fri, 8 Nov 2024 21:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731099689; cv=none; b=uDl+7Pgv7szmViIYE95zwZeht0J3CIfdhq3P5AQ206tIar6xSBrwzaym9rUDtZA9+jxdS26lwooQlVc5YdGxaMPuiJDEX1KFdfL2nU36O9yrBvfoOlluNr/fSpb06Ya/s5hv1WUoXgwN3FSJxdXsZzgYBNefFlltdKQTpGIg/o0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731099689; c=relaxed/simple; bh=VDBbkVz7T2RTxe1AH3XRhRFcEO2Wl5d6RIbEYH/izOY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pR81iuNEJugE+K9wXiNo3dIGgVfYl/ZL/GZAg7MiqvFH3FS9aVn0In0qgafKUUjPlGNaFThqxi7pm7hL3d6/orD51q9HrIkV2jiEg9wDyI3lZ2YuCVgTK6Dq7gCd/5ts2B1YGM2qd1JshSXa9BPewSWJo1N1xjz6wz0/Du6g3Jk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jEoDmuUL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jEoDmuUL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731099686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kimPDf4rDLcQh3sGbwpWiBCPrIwWEalWkLN0T0v4qh8=; b=jEoDmuULbVji1YSl7br82xPBldsOceOEkEknV/+CX02J5hw5QDD06qOcTHeGeBd7aQ7yxJ 5WQTQZ0yPtrrP1rDNrBaJQVvNViViXewXmJ0UNp0BSUYsT/hElGzap/rKPopXYCMCtxvYG dx/IAHqq1YXrHz2m+1X9d2b9YjWMlKk= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-96-xcNAQXJ6PXahEZnD_xY1dg-1; Fri, 08 Nov 2024 16:01:25 -0500 X-MC-Unique: xcNAQXJ6PXahEZnD_xY1dg-1 X-Mimecast-MFC-AGG-ID: xcNAQXJ6PXahEZnD_xY1dg Received: by mail-io1-f69.google.com with SMTP id ca18e2360f4ac-83adf2baf76so50904339f.0 for ; Fri, 08 Nov 2024 13:01:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731099684; x=1731704484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kimPDf4rDLcQh3sGbwpWiBCPrIwWEalWkLN0T0v4qh8=; b=WQiqNTcyGTZHCWEM9IAH1lVw8jZsM1ZcKhrZs1jjHNy/6pPqBMByJumU6rx265P0LX yPc4X7vcb6ig2vJnuP6BukcqFiAF9noK9VvBN/P76sZlSPOtjie5UejjeHeKm+zYsap5 cM5lIOMqGLXr5dkN+WamkXt5b8TANULgPWaKf0+FFsCtB42YHQTq6UmUNYRjFodojII+ 3MASVfsaVBW8uIyyoUJoYa8d7nSo5J2nBzlKfZz20a1kU+324vodhl7AmCVG/+rm/02t Yyi3+y/VPc4BUN8nR3HC5Gm9s1lH/FLfsltvd72LTvPcF51Vth1n3WPkgfkNKgXbo8xg FLPQ== X-Forwarded-Encrypted: i=1; AJvYcCUOIxxD4PstX5hzs3oU4ec73QeLeHfAIhdwPGkIntCvwUlmKBtp0baafEgSSFKhhP4JutpMS9nV2pCisYY=@vger.kernel.org X-Gm-Message-State: AOJu0YyVLDT1V/pUlAjmhy0yuYfA1oX8RmV8AXKSh3mTA+tsANjbkOU9 eTUOA7fpMwp4hIDmzAb9gT+zB09VcOw53woMH7EWyxtGw6OLXtVgffW4EcUQHtOy48zVSnd4Zw3 +dYV9YBACOdbv2a7bn5nYGWZGhC1X5TJAXSnpvQKd8LQihBCl49a25wQXnO/qwg== X-Received: by 2002:a05:6602:1550:b0:83a:e6b2:be3 with SMTP id ca18e2360f4ac-83e03078700mr142695039f.0.1731099684322; Fri, 08 Nov 2024 13:01:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGYC+igGRtK8/3QlUfGuT32tq/ShwHiJN1Q3xo+UqZRuBVIQpMGWi7EzsrfF7s6NSiJw+VE0w== X-Received: by 2002:a05:6602:1550:b0:83a:e6b2:be3 with SMTP id ca18e2360f4ac-83e03078700mr142693239f.0.1731099683826; Fri, 08 Nov 2024 13:01:23 -0800 (PST) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-83df503d503sm99452939f.18.2024.11.08.13.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2024 13:01:22 -0800 (PST) Date: Fri, 8 Nov 2024 14:01:21 -0700 From: Alex Williamson To: Longfang Liu Cc: , , , , , Subject: Re: [PATCH v14 0/4] debugfs to hisilicon migration driver Message-ID: <20241108140121.1032a68a.alex.williamson@redhat.com> In-Reply-To: <20241108065538.45710-1-liulongfang@huawei.com> References: <20241108065538.45710-1-liulongfang@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 8 Nov 2024 14:55:34 +0800 Longfang Liu wrote: > Add a debugfs function to the hisilicon migration driver in VFIO to > provide intermediate state values and data during device migration. > > When the execution of live migration fails, the user can view the > status and data during the migration process separately from the > source and the destination, which is convenient for users to analyze > and locate problems. > > Changes v13 -> v14 > Bugfix the parameter problem of seq_puts() Should we assume this one is at least compile tested? Thanks, Alex > > Changes v12 -> v13 > Replace seq_printf() with seq_puts() > > Changes v11 -> v12 > Update comments and delete unnecessary logs > > Changes v10 -> v11 > Update conditions for debugfs registration > > Changes v9 -> v10 > Optimize symmetry processing of mutex > > Changes v8 -> v9 > Added device enable mutex > > Changes v7 -> v8 > Delete unnecessary information > > Changes v6 -> v7 > Remove redundant kernel error log printing and > remove unrelated bugfix code > > Changes v5 -> v6 > Modify log output calling error > > Changes v4 -> v5 > Adjust the descriptioniptionbugfs file directory > > Changes v3 -> v4 > Rebased on kernel6.9 > > Changes 2 -> v3 > Solve debugfs serialization problem. > > Changes v1 -> v2 > Solve the racy problem of io_base. > > Longfang Liu (4): > hisi_acc_vfio_pci: extract public functions for container_of > hisi_acc_vfio_pci: create subfunction for data reading > hisi_acc_vfio_pci: register debugfs for hisilicon migration driver > Documentation: add debugfs description for hisi migration > > .../ABI/testing/debugfs-hisi-migration | 25 ++ > .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 266 ++++++++++++++++-- > .../vfio/pci/hisilicon/hisi_acc_vfio_pci.h | 19 ++ > 3 files changed, 279 insertions(+), 31 deletions(-) > create mode 100644 Documentation/ABI/testing/debugfs-hisi-migration >