From: David Wang <00107082@163.com>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, David Wang <00107082@163.com>
Subject: [PATCH 01/13] kernel/irq/proc: use seq_put_decimal_ull_width() for decimal values
Date: Sat, 9 Nov 2024 00:07:17 +0800 [thread overview]
Message-ID: <20241108160717.9547-1-00107082@163.com> (raw)
seq_printf() is costy, on a system with m interrupts and n CPUs, there
would be m*n decimal values yield via seq_printf() when reading
/proc/interrupts, the cost parsing format strings grows with number of
CPU. Profiling on a x86 8-core system indicates seq_printf() takes ~47%
samples of show_interrupts(), and replace seq_printf() with
seq_put_decimal_ull_width() could have near 30% performance gain.
The improvement has pratical significance, considering many monitoring
tools would read /proc/interrupts periodically.
Signed-off-by: David Wang <00107082@163.com>
---
kernel/irq/proc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
index 9081ada81c3d..988ce781e813 100644
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -494,9 +494,11 @@ int show_interrupts(struct seq_file *p, void *v)
if (!desc->action || irq_desc_is_chained(desc) || !desc->kstat_irqs)
goto outsparse;
- seq_printf(p, "%*d: ", prec, i);
+ seq_printf(p, "%*d:", prec, i);
for_each_online_cpu(j)
- seq_printf(p, "%10u ", desc->kstat_irqs ? per_cpu(desc->kstat_irqs->cnt, j) : 0);
+ seq_put_decimal_ull_width(p, " ",
+ desc->kstat_irqs ? per_cpu(desc->kstat_irqs->cnt, j) : 0,
+ 10);
raw_spin_lock_irqsave(&desc->lock, flags);
if (desc->irq_data.chip) {
--
2.39.2
next reply other threads:[~2024-11-08 16:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 16:07 David Wang [this message]
2024-11-13 16:44 ` [tip: irq/core] genirq/proc: Use " tip-bot2 for David Wang
2024-11-13 19:10 ` [PATCH 01/13] kernel/irq/proc: use " Thomas Gleixner
2024-11-14 12:10 ` David Wang
2024-11-19 19:55 ` Geert Uytterhoeven
2024-11-20 1:20 ` Thomas Gleixner
2024-11-20 1:36 ` David Wang
2024-11-20 4:24 ` David Wang
2024-11-26 17:40 ` Thomas Gleixner
2024-11-27 0:07 ` David Wang
2024-11-20 8:56 ` Geert Uytterhoeven
2024-12-03 10:40 ` [PATCH] genirq/proc: Add missing space separator back Thomas Gleixner
2024-12-03 11:19 ` David Wang
2024-12-03 11:21 ` [PATCH] " Geert Uytterhoeven
2024-12-03 13:56 ` Thomas Gleixner
2024-12-03 14:11 ` [tip: irq/urgent] " tip-bot2 for Thomas Gleixner
2024-11-20 1:37 ` [PATCH 01/13] kernel/irq/proc: use seq_put_decimal_ull_width() for decimal values David Wang
2024-11-20 2:08 ` David Wang
2024-11-20 9:00 ` Geert Uytterhoeven
2024-11-20 9:36 ` David Wang
2024-11-20 9:56 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108160717.9547-1-00107082@163.com \
--to=00107082@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®