From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70AEE14D70E; Mon, 11 Nov 2024 13:30:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731331858; cv=none; b=GSn7wBU/Z2/EYylFIr38vdeMdhwSK0O5viQtfc6hp1mhKOj4LSUM2TBKovYC82m+lLEnqqObZ8qlAAo+UPrzGfAiXC+Sgj4+k3x818G2Nw/c/BBGr6o+6cutaLLzALkoXJq/FIic+Z6sN4BKUv0Y/GBWwITCjEY7s64b+HWUnyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731331858; c=relaxed/simple; bh=Q4A1KeBAs2YII4rolHw/9G6jmTx1rDWLERDwHLNEtbE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tAL8E0iJCVioIIr70MbljiazfX8iMEXEGmBLN6x7dJkRmKZLqsKe8FfQvIz8sYdpJYw58/yQDt9g96UU6s5fU+2yJuQ6W85dl9sHM686vWT1GocmOTFhTvtRubbyrvaNkj7xgq5Q1YD6qadZeUS02Xgaz3gNcDxxcyCtdH1Ngj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tj9mN+bP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tj9mN+bP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB095C4CECF; Mon, 11 Nov 2024 13:30:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731331858; bh=Q4A1KeBAs2YII4rolHw/9G6jmTx1rDWLERDwHLNEtbE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tj9mN+bPb4grEnWTKOkrAzZP/iKAZCD4lZ6NfoBZwoe1i/KfIy4x4k1UuJ35Wm0/a f5IcjrYmMgxDWJz64fEulzauTdydGDqQ0/B3dMNxFTZFzpVJe9L3S+dENAJA8Ow8eL naUhfA8BUHSKyeYAliquCyqp3sfLiVI3Yl9jowijXROX2042IHEimIzWvuYr8br2JM OYSuC/yqLPCZU0/GrTJjQEcQJcX3RGO/Fi3VCZ1xfSpJAtNUd3kvZ8hsqMmqLRjVgM 4xhmniJPa8XwKir4uxYIIrWqTM6DKI0Yd9X6k3oQC4pkkNotJHz7qqA5HzGiuwy3EN yhVjDS16qDQZw== Date: Mon, 11 Nov 2024 14:30:53 +0100 From: Christian Brauner To: Jeff Layton Cc: Miklos Szeredi , Alexander Viro , Jan Kara , Ian Kent , Josef Bacik , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] fs: add the ability for statmount() to report the fs_subtype Message-ID: <20241111-apparat-zurschaustellen-9929ff182ab6@brauner> References: <20241107-statmount-v3-0-da5b9744c121@kernel.org> <20241107-statmount-v3-1-da5b9744c121@kernel.org> <17fde675e5cba387b45a68344f6c6f0394d8959a.camel@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <17fde675e5cba387b45a68344f6c6f0394d8959a.camel@kernel.org> On Mon, Nov 11, 2024 at 08:28:07AM -0500, Jeff Layton wrote: > On Mon, 2024-11-11 at 14:01 +0100, Miklos Szeredi wrote: > > On Mon, 11 Nov 2024 at 12:28, Jeff Layton wrote: > > > > > As far as I can tell, the existing cases in statmount_string() either > > > always emit a string or an error code. If a string isn't emitted, then > > > the two EOVERFLOW cases and the EAGAIN case can't happen, so I don't > > > think this will result in any change in behavior for the existing code. > > > > Both mnt_point and mnt_opts can be empty. > > > > Ok, so currently if they are, the flag gets set and there is no > string?  If so, then you're correct and this is a behavior change. The > question is -- is it a desirable one? The interface is new enough that > I think we have the luxury of changing this now (and establishing a > future standard). > > Personally, I think that's how it ought to work. When there is no > string present, we ought not set the flag in the return mask. Does > anyone prefer it the other way? It's a change we can certainly do. I see no reason not to try it.