From: Peter Zijlstra <peterz@infradead.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/topology: Correctly propagate NUMA flag to scheduling domains
Date: Mon, 11 Nov 2024 10:22:46 +0100 [thread overview]
Message-ID: <20241111092246.GC22801@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241109145628.112617-1-arighi@nvidia.com>
On Sat, Nov 09, 2024 at 03:56:28PM +0100, Andrea Righi wrote:
> @@ -1974,6 +1981,7 @@ void sched_init_numa(int offline_node)
> */
> tl[i++] = (struct sched_domain_topology_level){
> .mask = sd_numa_mask,
> + .sd_flags = cpu_numa_flags,
> .numa_level = 0,
> SD_INIT_NAME(NODE)
> };
This doesn't seem right. This level is a single node, and IIRC we only
expect SD_NUMA on cross-node domains.
next prev parent reply other threads:[~2024-11-11 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 14:56 Andrea Righi
2024-11-11 9:22 ` Peter Zijlstra [this message]
2024-11-11 14:32 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111092246.GC22801@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®